Thanks Josh. I think some of the fields I was concerned about ex. private final Pattern validatorPattern = Pattern.compile(VALIDATOR_PATTERN);
would just be final, and not static - probably wasn't giving solid enough examples, but I have enough to go on now, and have identified a small number of areas I'm going to update. Worth highlighting anyway I think, as the kind of errors that can creep in a hard to pin down (at least for me!). Thanks. Regards, Jim. -----Original Message----- From: Josh Canfield [mailto:joshcanfi...@gmail.com] Sent: 22 January 2011 14:27 To: Tapestry users Subject: Re: T.5.2.x Possible page pooling removal impact query > As far as I can remember, the removal of the page pool only affects *non*-static fields. Static variables wouldn't be affected only because they already needed to be thread safe. On Jan 21, 2011 6:48 PM, "Thiago H. de Paula Figueiredo" <thiag...@gmail.com> wrote: >> >> Anyone care to have a quick glance at the attachment for coding red flags >> they could highlight, or even just advise on whether it is a question of >> tracking down third party source to check if there are thread safety issues in any of their called methods? Thanks a million. > > > As far as I can remember, the removal of the page pool only affects *non*-static fields. Anyway, as a general rule, you should never initialize a non-static field in its declaration (unless the value is immutable). > > Your code only has static fields, so using or not the page pool won't make any difference at all. > > -- > Thiago H. de Paula Figueiredo > Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and instructor > Owner, Ars Machina Tecnologia da Informação Ltda. > http://www.arsmachina.com.br > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
