I just did a very, very quick review of the code for the demo. Overall I think this is a great thing, and it has just enough complexity to be interesting without being so involved that people can't grasp it.
That being said I have a few critiques (I've added a more detailed checklist of issues to the GitHub issues). As a demo, the code should be as clean and simple as possible. I'm concerned that the conversation system is overkill, and I saw a few other areas where things could be simplified. On Thu, Oct 21, 2010 at 9:11 AM, Howard Lewis Ship <hls...@gmail.com> wrote: > You might as well use the tapx-datefield module as well. > > If things ever wind down on my current projects, I have lots of ideas > to spin off into tapestry-core and tapx. I can't wait! > > On Thu, Oct 21, 2010 at 8:16 AM, Katia Aresti Gonzalez > <katiaare...@gmail.com> wrote: >> Well, we can remove it if you wish Christophe >> >> Or we can just add a comment to say that - as always - there is one >> exception that confirms the rule :-) Kaptcha - as it's a tapx component. >> >> Katia >> >> 2010/10/21 Christophe Cordenier <christophe.corden...@gmail.com> >> >>> 2010/10/21 Piero Sartini <li...@pierosartini.de> >>> >>> > Very nice effort! >>> > >>> >>> Thanks ! >>> >>> >>> > >>> > Is the captcha a tapestry core component? Just because on the first >>> > page it reads: >>> > >>> >>> Almost, tapx has been written by Howard :) To be complete third-party free >>> we should remove it or implement it in the project. >>> >>> >>> > "This version of the application uses only Tapestry's core components, >>> > thus you will find here a *realistic* demonstration of Tapestry's >>> > power." >>> > >>> > Piero >>> > >>> > --------------------------------------------------------------------- >>> > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org >>> > For additional commands, e-mail: users-h...@tapestry.apache.org >>> > >>> > >>> >>> >>> -- >>> Regards, >>> Christophe Cordenier. >>> >>> Committer on Apache Tapestry 5 >>> Co-creator of wooki @wookicentral.com >>> >> > > > > -- > Howard M. Lewis Ship > > Creator of Apache Tapestry > > The source for Tapestry training, mentoring and support. Contact me to > learn how I can get you up and productive in Tapestry fast! > > (971) 678-5210 > http://howardlewisship.com > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
