Thanks Howard. Understandable and yes, I realize PageResponseRenderer is internal but as I see it, adding the call makes sense for this use case and shouldn't cause problems even if it's called "just in case". Opened https://issues.apache.org/jira/browse/TAP5-1201 for it.
Kalle On Mon, Jul 5, 2010 at 10:34 AM, Howard Lewis Ship <hls...@gmail.com> wrote: > I suppose it could; just a case of unexpected use of the APIs. As > currently coded, we assume that the active page is identified by the > component event or page render dispatcher. > > On Sun, Jul 4, 2010 at 4:05 PM, Kalle Korhonen > <kalle.o.korho...@gmail.com> wrote: >> (Related to Tynamo's tapestry-security, >> http://tynamo.org/tapestry-security+guide) >> >> A custom exception handler added as an advice for the default one >> wants to handle some specific type of exceptions and proceeds to call >> PageResponseRenderer.render() in those cases. This works without >> issues in T5.1 but in T5.2 ComponentSource.getActivePage() throws >> "org.apache.tapestry5.ioc.internal.util.TapestryException: The >> identity of the active page for this request has not yet been >> established". To fix the issue, I can call the newly added >> RequestGlobabls.storeActivePageName(String pageName) before call to >> render(). While it's an easy fix, it'd be nicer if >> PageResponseRenderer.render() would just do that internally. Is there >> some reason why this would be a bad idea? >> >> Kalle >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: users-h...@tapestry.apache.org >> >> > > > > -- > Howard M. Lewis Ship > > Creator of Apache Tapestry > > The source for Tapestry training, mentoring and support. Contact me to > learn how I can get you up and productive in Tapestry fast! > > (971) 678-5210 > http://howardlewisship.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
