Re: (newbie) Tapestry generated

[akira]

HI, thanks for the reply, i voted for the bug to be fixed and i'm  
using the <span/> temporarily and i'm going to try Nicolas override  
method (didn't test on IE yet).
On Nov 25, 2008, at 11:33 PM, [EMAIL PROTECTED]  
wrote:

From: Peter Stavrinides <[EMAIL PROTECTED]>
Date: November 25, 2008 4:12:41 PM JST
To: Tapestry users <users@tapestry.apache.org>
Subject: Re: (newbie) Tapestry generated <b/>

Tapestry is meant to generate valid XHTML, which means the tag  
should be closed, but due to a bug introduced recently it appears  
not to with certain tags see:
https://issues.apache.org/jira/browse/TAP5-333 and vote for it to be  
fixed, in the meantime use a <span /> instead, it will work... I use  
the same rounded corner trick!

cheers,
Peter


From: Nicolas Charles <[EMAIL PROTECTED]>
Date: November 25, 2008 11:32:27 PM JST
To: Tapestry users <users@tapestry.apache.org>
Subject: Re: (newbie) Tapestry generated <b/>


You could override the MarkupWriterFactory to prevent the  
abreviation of the <b/> tag
It should look like this

public class XhtmlMarkupWriterFactoryImpl implements  
MarkupWriterFactory {
    private final String applicationCharset;
    private final MarkupModel xmlModel = new DefaultMarkupModel()  
{          private final Set<String> DONT_ABRV = new  
HashSet<String>(Arrays.asList("b", "select"));
        @Override
      public EndTagStyle getEndTagStyle(String element) {
          boolean isDontAbr = DONT_ABRV.contains(element);
          return isDontAbr ? EndTagStyle.REQUIRE :  
EndTagStyle.ABBREVIATE;
        }
            @Override
      public boolean isXML() {
          return true;
      }
  };
}

and alias it in the AppModule :
public static void  
contributeAlias 
(Configuration<AliasContribution<MarkupWriterFactory>> configuration,
                              @Inject  
@Symbol(SymbolConstants.CHARSET) final String applicationCharset) {
       
configuration.add(AliasContribution.create(MarkupWriterFactory.class,
              new XhtmlMarkupWriterFactoryImpl(applicationCharset)));
  }


Note that i don't abbreviate the select either, for IE doesn't  
understand at all an empty <select/>

Regards
Nicolas