Harald,

I'm honestly not clear on what the initial issue with that was (I'm not
the original author), but it may have had to do with the fact that the
component wrote out script code directly using the MarkupWriter instead
of PageRenderSupport. It was originally written for a much earlier
version of T5, so naturally things have streamlined.

Anyway, it's been removed and committed as my quick tests didn't yield
any problems. For further chats/concerns/requests with this component,
please use its associated user list or issue system:

http://groups.google.com/group/t5components-user
http://code.google.com/p/tapestry5-components/issues/list

sincerely,
chris

Harald Geritzer wrote:
>
> hi chris,
>
> after having a second look at your code i think you don't even need
> the replacement at all
> as the new version uses the "replaceTextArea()" instead of assigning
> the text via javascript.
> in writeScript() the replacement of \r,' occurs but _value is written
> out before in afterRender() and is not used again after the replacement.
>
> harald
>
> Chris Lewis schrieb:
>> Harald,
>>
>> Can I convince you to file an issue, if that is an issue?
>>
>> http://code.google.com/p/tapestry5-components/issues/list
>>
>> If you can, provide an example situation that would cause a problem.
>>
>> thanks!
>>
>> Harald Geritzer wrote:
>>> Chris Lewis schrieb:
>>>> Hi Harald,
>>>>
>>>> tapestry5-components has an editor component (which uses fck):
>>>>
>>>> http://87.193.218.134:8080/t5components/t5c-commons/ref/org/apache/tapestry/commons/components/Editor.html
>>>>
>>>>
>>> ty,
>>>
>>> guess in writeScript():
>>>
>>> _value = _value.replace('\r', '\\');   //this is needed for javascript
>>> to be able to extend a string                     across multiple lines
>>> _value = _value.replace("'", "'"); //this is needed because the
>>> string delimiter is ' for the                         script below
>>>
>>> _value.replace should be better replaced by _value.replaceAll  ?
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-- 
http://thegodcode.net


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to