Nice.  You avoided all the deprecated functions too (gotta love those Java
dates).

One gotcha I noticed was that the SimpleDateFormat objects are static, and
they're not thread safe by nature (at least according to the JavaDoc). 
Those should probably be instance variables instead of statics.

Thanks for the fix!
Jon


Jessek wrote:
> 
> Thanks for noticing. I didn't follow the exact pattern that you
> outlined but have made them rfc3339 compliant and things look much
> better now.
> 
> Should be available at some point today.
> 
> On 12/15/06, Jon McCarty <[EMAIL PROTECTED]> wrote:
>>
>> Hi everyone –
>>
>> I'm enjoying the Tap4.1.1 line (I think that's where I am – I'm pulling
>> from
>> svn trunk), but I had a problem with the Dojo-backed dropdown date and
>> time
>> pickers.
>>
>> Right now, they're passing the dates to the client-side components in a
>> way
>> that causes the client-side to do a timezone conversion.  This throws off
>> my
>> app when the client is in a different timezone than the server.
>>
>> For my $0.02, the server should control all timezone issues – I want
>> times
>> rendered as text to be the same as the ones in my widgets!  I'd like to
>> recommend this change for the Tapestry trunk:
>>
>> Change how we pass the date in DropdownDatePicker and DropdownTimePicker
>> to
>> this code fragment:
>>
>>
>> Object formatted = new JSONLiteral("new Date(" + (value.getYear()+1900) +
>>                                    "," + value.getMonth() +
>>                                    "," + value.getDate() +
>>                                    "," + value.getHours() +
>>                                    "," + value.getMinutes() +
>>                                    "," + value.getSeconds() + ")");
>> json.put("value", formatted);
>>
>>
>> This works for both the date and time pickers.  (Currently, the time
>> picker
>> doesn't work at all, probably due to a recent change in Dojo's formatting
>> requirements.)
>>
>> Comments?  Should I open a JIRA to this effect?
>>
>> --JM
>>
>> --
>> View this message in context:
>> http://www.nabble.com/DropdownTimePicker%2C-DropdownDatePicker%2C-and-time-zones-tf2828601.html#a7896437
>> Sent from the Tapestry - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> 
> -- 
> Jesse Kuhnert
> Tapestry/Dojo team member/developer
> 
> Open source based consulting work centered around
> dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/DropdownTimePicker%2C-DropdownDatePicker%2C-and-time-zones-tf2828601.html#a8013696
Sent from the Tapestry - User mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to