On 09/09/2014 07:04 AM, Henrik K wrote:
On Tue, Sep 09, 2014 at 03:45:33AM +0200, Karsten Bräckelmann wrote:There is one down side: A new dependency on Regexp::List [1]. The RE pre-compile one-time upstart penalty should be negligible. [1] Well, or a really, really f*cking ugly option that takes a pre-optimzed qr// blob containing the VALID_TLDS_RE.I think it's even mentioned on the bug. There's NO need for any deps. Perl 5.10+ already trie optimizes a|b|c lists internally. Just concatenate and be done with it. If you _really_ want to cater for 5.8 losers, the simple shuffling "Regexp::List" does could be implemented internally in few lines of code..
is your your Freemail plugin seems to be the only one accessing the VALID_TLDS_RE list...
