On Sunday 30 March 2014 13:52:43 Ivo Truxa wrote: > Nuno Fernandes-2 wrote > > > Yes.. you are correct. The result is not added to the AWL database but i'm > > ok with that. > > Personally I think it makes no sense using AWL when you do not let it work,
Oh.. but it works. Only in some scenarios i would like it to be disabled (scoring and adding to the DB). > and do not store all scores. A better place to make the modification is at > the bottom of the sub check_from_in_auto_whitelist(), in the condition "if > ($delta != 0)". Store the value of the noawl tag in the loop where your > current code is, but don't return from there. Let the sub parse through, and > skip returning the delta score at the bottom. Yes.. but in this case i'm doing unnecessary cpu instructions only to record in db the value. For me the flag noawl should be to disable all awl features. If I created something like the flag "noawlscoring" your idea seems fine. > However, unless you manage to get this modification to the official code, > you have to redo the patch after each update, so as I wrote previously, IMHO > the better way to handle it, is adjusting the tag scores so that you do not > need to disable AWL. You could also write a rule based on the concerned tag > values, in combination with the AWL value, so that it does the same trick > without the need to hack the code. Something in a way similar to this one: > > meta AWL_FIX (URIBL_DBL_SPA || SOMETHING_ELSE || ANOTHER_ONE) && AWL < -3 > describe AWL_FIX Suppressing AWL > priority AWL_FIX 1100 > score AWL_FIX 5.0 I've considered and even implemented rules similar to the above but they all remain short off completely remove the awl score. I need this to have complete predictability of the final score on some emails that had the same issue of awl working against the sysadmin (like you've stated in your TxRep code). > It is always preferable customizing your installation through settings and > rules, than hacking the code. Yes.. but i already maintain our company spamassassin package with some other patches (a lot bigger that this) and this oneliner is trivial to maintain (at least for now). Best regards, Nuno Fernandes
