On Fri, May 21, 2010 at 6:39 AM, Mark Martinec <mark.martinec...@ijs.si> wrote: >> > It's the same issue as was already resolved for the ClamAV plugin, >> > the data structure changed from hash to a list (so that ordering >> > of add_header can be maintained). >> > >> > See: >> > https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6254 >> >> Ah, thank you. I made this change in POPAuth.pm at line 199: >> >> -- $opts->{permsgstatus}->{main}->{conf}->{headers_ham}->{POPAuth} = 'No'; >> -- $opts->{permsgstatus}->{main}->{conf}->{headers_spam}->{POPAuth} = 'No'; >> ++ push @{$opts->{permsgstatus}->{main}->{conf}->{headers_ham}}, >> ["POPAuth", 'No']; >> ++ push @{$opts->{permsgstatus}->{main}->{conf}->{headers_spam}}, >> ["POPAuth", 'No']; >> >> and it seems to be working now. If any perl gurus have any tips / >> correction for the above code, please let me know. :) > > Please read the Bug 6254 comments to the end. > > The above simple solution only works for one-time invocations > of spamassassassin, e.g. from a command line. When multiple > tasks in the same process are involved (spamd, amavisd), > these headers will accumulate, a proper solution is > for a plugin to add a tag (like POPAUTH), then use add_header > config directive to insert such tag into a mail header section. > See plugins ClamAVPlugin and/or ASN for implementation example. > Such solution is compatible with 3.2 and with 3.3.
Thanks Mark. I tried a few code changes, but kept getting blessing errors, etc... so my perl/SA skills are not up to par. If anyone can convert the plugin code to the new standard, that would be helpful to anyone using this plugin. :) Rob
