2009/5/4 Karsten Bräckelmann <guent...@rudersport.de>: >> via https://issues.apache.org/SpamAssassin/show_bug.cgi?id=2865. In > > No commit pointer. I'm lazy, Theo, any hints to the actual commit so I > don't have to dig? :)
Sure. I found it by a) looking at the code and validating my understanding, and b) looking at svn log and finding: ------------------------------------------------------------------------ r157204 | jm | 2005-03-11 21:02:03 -0500 (Fri, 11 Mar 2005) | 1 line bug 2788: doco fixes for blacklist rules where autolearning is concerned; also bug 2865: don't learn messages as ham if they were previously marked spam by the classifier (due to blacklists etc.), and vice-versa. ------------------------------------------------------------------------ That said, the diff doesn't really show much, and "svn blame" actually points at r149224 instead: ------------------------------------------------------------------------ r149224 | jm | 2005-01-31 00:52:33 -0500 (Mon, 31 Jan 2005) | 1 line move default Bayes auto-learn discriminator out of core, into an active-by-default plugin, so that it can be overridden if desired ------------------------------------------------------------------------ so then you have to find the original module. I thought it was Bayes.pm, but it's actually PerMsgStatus.pm, which makes sense when I think about it some more ... However, finding when the code got added was hard -- I ended up doing a binary search w/ "svn cat" and ended up here, which was the first mention of learner_said_ham_points: ------------------------------------------------------------------------ r6746 | duncf | 2004-02-18 20:24:48 -0500 (Wed, 18 Feb 2004) | 1 line Bug 1332: replace hits with points (or score) internally and externally... Some variable names have changed, notably $self->{hits} is now $self->{score}. Backwards compatibility is maintained where possible ------------------------------------------------------------------------