William Taylor writes:
> On Fri, Apr 18, 2008 at 06:22:58PM +0100, Justin Mason wrote:
> > William Taylor writes:
> > > Is there anyway to extend this in DNSEval.pm locally without patching?
> > > Maybe with a plugin or something?
> > >
> > > my @originating = ();
> > > for my $header ('X-Originating-IP', 'X-Apparently-From') {
> > > my $str = $pms->get($header);
> > > next unless $str;
> > > push (@originating, ($str =~ m/($IP_ADDRESS)/g));
> > > }
> > >
> > > I want to add a few headers here but I didn't want to have to patch on
> > > each upgrade.
> >
> > hi William --
> >
> > meant to reply to your private mail, but list mail is better ;) The best
> > bet to get it into the mainline is to add a configuration setting to
> > Conf.pm, specifying the names of additional headers to look up.
> >
> > Failing that, why not add your additional headers using
> > "X-Originating-IP" in the first place? ;)
>
> No worries Justin.. Thought about the list today lol
>
> Isn't Conf.pm overwritten when upgrading?
hi William -- yes, the idea however is that you write some code that
we'd be happy to put into our "upstream" released version. Then in
future you won't have to add your own site-specific patch for that!
> Can you give me an example of what I would put in there or point me in the
> right direction?
it'd be a new configuration parameter in the large array of structures
in Conf, to specify additional headers for that list.
If you want, open an enhancement request bug in our bugzilla, and I
may be able to do it ;)
--j.
