We have had issues with shortcircuit that cropped up.in the rc process from optimization that was performed. Can you open up bugzilla ticket please?
On Tue, Dec 13, 2022, 08:37 Greg Troxel <g...@lexort.com> wrote: > > I am finding that short-circuiting seems not to be working, but this is > not new and I am not 100% clueful about it. However in trying to figure > things out I am running into things I do not understand and think that > at least a bit more doc clarity would help. > > I have a fairly normal installation, milter with postfix, base rules, > KAM, some custom rules, and (now with 4.0.0rcN, renamed) a bunch of > welcomelist, which I try to do with dkim, then rcvd and for some give up > and just welcomelist. Plus a bunch of blocklist. These rules work and > I get sensible scores with occasional minor issues. > > I just got a mail which was a little spammy and reasonably got 1.4, but > I decided to call it ham and added a "welcomelist_from_dkim > n...@example.com mailchimpapp.net". It then scored -98.6, so that's > good. > > I had in local.cf; > > shortcircuit USER_IN_WELCOMELIST on > > and realized that doesn't cover USER_IN_DKIM_WELCOMELIST, so I added > > shortcircuit USER_IN_DKIM_WELCOMELIST on > > but still scoring looks like: > > -0.0 USER_IN_DKIM_WELCOMELIST From: address is in the user's DKIM > -100 USER_IN_DKIM_WHITELIST DEPRECATED: See USER_IN_DKIM_WELCOMELIST > > plus a bunch of other stuff including network tests (all done > correctly). It took 36 seconds and there was no sign of short > circuiting. > > The wiki page in the release notes says: > > In SpamAssassin version 4.0.0 all rules, functions, command line > options and modules that contain "whitelist" or "blacklist" have > been renamed to contain "welcomelist" and "blocklist" terms. This > allows acronyms like WL and BL to remain the same. Previous options > will continue work at least until version 4.1.0 is released. If you > have local settings including scores or meta rules referring to old > rule names, these should be changed and "enable_compat > welcomelist_blocklist" added in init.pre. > > I haven't enabled compat, but I did rename. I would expect that with > the transition to new keywords in 4.0.0, the normal approach is to edit > one's config and be all set. Or, one could leave the old words and have > them treated as compatible, maybe with a warning. Or possibly have to > enable compatibility for the old ones. > > Am I really supposed to change the keywords to welcome/block *and* set > "enable_compat"? The man page Mail::SpamAssassin::Conf.3 doesn't say > that, that I was able to find. > > I wonder if I am not getting short circuit because the -100 is awarded > to USER_IN_DKIM_WHITELIST, not USER_IN_DKIM_WELCOMELIST? Or is DKIM a > network test, and thus doesn't really work for short circuiting? > Something else? > > (I realize that 36s is a clue that an RBL is being queried that times > out and I should find and fix that, but I think that's orthogonal to my > questions.) >
