Hi,

I observed with miltrassassin (Revision: 1.14 Date: 2003/05/28 18:43:47)
from check_local.5.6.tar.gz formerly available at
http://www.digitalanswers.org/check_local/check_local.5.6.tar.gz
the following bug:

Miltrassassin generates a Received: header for the HELO part of the SMTP
protocol. The generated Received: header is not correctly parsed if there
was no HELO string. For such cases the Received line generated looks like

Received: from  (24-197-144-165.cpe.ga.charter.com [24.197.144.165]) by ...
              ^^^
A simple change in miltrassassin.c:

328c328
<               priv->mlfi_helo ? priv->mlfi_helo : "",
---
>               priv->mlfi_helo ? priv->mlfi_helo : "nohelo",

does fix that. This is BTW the (better) behaviour of spamass-milter.

The score difference for SPAM mails with and without that fix is dramatic,
I have seen score changes like 3.8 -> 15.7 or 10.5 -> 27.3
Therefore this fix should be applied for those who are still using
miltrassassin.

-- 
Wolfgang Friebel    Deutsches Elektronen-Synchrotron DESY

Reply via email to