On Fri, Sep 17, 2004 at 06:38:48PM -0400, Theo Van Dinter wrote:
> On Fri, Sep 17, 2004 at 03:30:36PM -0700, Will Yardley wrote:
> > Shouldn't the SA build & test process be a little more verbose about
> > this, though, and at least spit out some warnings about missing Perl
> > modules? While the dnsbnl tests may not be necessary for SA to work,
> > it's certainly a lot more effective with them.
> That's just it though -- it's optional, as you've stated. Just because it
> makes SA more effective doesn't make it required. ;)
Sure, but "make test" just says something like "test failed: no reason
given" - it could at least say that the test failed because Net::DNS is
missing.
Also, if Net::DNS is installed, but not the required version, SA doesn't
give any errors (that I can see) during the install or test process -
tests simply fail - you have to enter into debug mode to get the message
"debug: Net::DNS version is 0.xx, but need 0.34" (which, among all of
that output, is pretty damn easy to miss).
For instance, w/ Net::DNS 0.19 (current version of the Debian stable
package):
t/dnsbl............. Not found: P_2 =
<dns:134.88.73.210.dnsbltest.spamassassin.org> [127.0.0.4]
Not found: P_7 =
<dns:134.88.73.210.sb.dnsbltest.spamassassin.org?type=TXT>
t/dnsbl.............NOK 2 Not found: P_4 =
<dns:14.35.17.212.dnsbltest.spamassassin.org> [127.0.0.1, 127.0.0.1]
Not found: P_3 = <dns:18.13.119.61.dnsbltest.spamassassin.org>
[127.0.0.12]
Not found: P_5 = <dns:226.149.120.193.dnsbltest.spamassassin.org>
[127.0.0.1]
t/dnsbl.............NOK 3 Not found: P_1 =
<dns:98.3.137.144.dnsbltest.spamassassin.org> [127.0.0.2]
(even though these records resolve fine on the system itself). A more
useful error would be:
"test failed because you don't have the requisite version of Net::DNS"
or something.
