Hi Jan, I don’t like the duplication either. I’ll try to revise the text reducing the duplication and enhancing the indication to read solr-source-code.adoc BTW, why isn’t possible run Solr directly from gradle? Could I contribute adding this little improvement? having just one task to build and run locally will shorten the documentation too.
Vincenzo D'Amore On Sat, 24 Feb 2024 at 00:38, Jan Høydahl <jan....@cominvent.com> wrote: > Hi, > > Thanks for this contrib. > > My only concern is that it is duplicating what is already explained in > https://github.com/apache/solr/blob/main/dev-docs/solr-source-code.adoc > But that file is also too hard to find, so agree the main README should at > least provide a hint on how to build and run locally. > Is it possible to shorten it down a tad in the PR and link directly to > solr-source-code.adoc? > > Jan > > > 23. feb. 2024 kl. 18:03 skrev Vincenzo D'Amore <v.dam...@gmail.com>: > > > > Hi Christine, Mikhail, I have prepared a little change to Solr docs. I > > have submitted the PR. > > > > https://github.com/apache/solr/pull/2294 > > > > Please let me know if anything is wrong with it or missing. > > > > Best regards, > > Vincenzo > > > > > > > > On Tue, Feb 20, 2024 at 11:38 AM Christine Poerschke (BLOOMBERG/ LONDON) > < > > cpoersc...@bloomberg.net <mailto:cpoersc...@bloomberg.net>> wrote: > > > >> Hello Rajani and Vincenzo, > >> > >> Thank you for your valuable feedback on the setup experience! > >> > >> Absolutely, yes please to updating the docs. No JIRA ticket needed IMHO. > >> > >> Best wishes, > >> Christine > >> > >> From: users@solr.apache.org At: 02/20/24 10:34:23 UTCTo: > >> users@solr.apache.org > >> Cc: solr-u...@lucene.apache.org > >> Subject: Re: Run solr in cloud mode and debug from intellij > >> > >> Should I create an issue (improvement) on jira first? > >> > >> > >> On Tue, Feb 20, 2024 at 11:29 AM Vincenzo D'Amore <v.dam...@gmail.com> > >> wrote: > >> > >>> Thanks, I'm going to do it. > >>> > >>> On Tue, Feb 20, 2024 at 11:23 AM Mikhail Khludnev <m...@apache.org> > >> wrote: > >>> > >>>> Yeah. Agree. A little bit cryptic. I'm up to approve your PR! > >>>> > >>>> On Tue, Feb 20, 2024 at 12:59 PM Vincenzo D'Amore <v.dam...@gmail.com > > > >>>> wrote: > >>>> > >>>>> Hi Mikhail, thanks for sharing. > >>>>> Maybe I haven't read the documentation carefully, but I had the same > >>>>> trouble, I spent a few hours struggling to understand how to build > and > >>>>> debug Solr locally. > >>>>> What do you think if we mention this resource directly into > >>>>> https://github.com/apache/solr/blob/main/dev-docs/README.adoc > >>>>> or even better into > >>>>> > >>>> > >> > https://github.com/apache/solr/tree/main?tab=readme-ov-file#get-involved > >>>>> ? > >>>>> > >>>>> On Tue, Feb 20, 2024 at 7:20 AM Mikhail Khludnev <m...@apache.org> > >>>> wrote: > >>>>> > >>>>>> Hello Rajani > >>>>>> This might be particularly useful > >>>>>> > >>>> > https://github.com/apache/solr/blob/main/dev-docs/solr-source-code.adoc > >>>>>> > >>>>>> ./gradlew dev will create a Solr executable suitable for > >> development. > >>>>>> Change directories via cd ./solr/packaging/build/dev and run the > >>>>>> bin/solr script > >>>>>> to start Solr. It will also create a "slim" Solr executable based on > >>>> the > >>>>>> "slim" Solr distribution. You can find this environment at > >>>>>> ./solr/packaging/build/dev-slim. Use either ./gradlew devSlim or > >>>>> ./gradlew > >>>>>> devFull to create just one type of distribution. > >>>>>> Do you need to debug some of SolrCloudTestCase subc(l)a(s)ses or > >> want > >>>> to > >>>>>> debug solr cloud instances? > >>>>>> > >>>>>> On Mon, Feb 19, 2024 at 8:02 PM rajani m <rajinima...@gmail.com> > >>>> wrote: > >>>>>> > >>>>>>> Hi Solr Devs, > >>>>>>> > >>>>>>> Are there any docs to debug solr in cloud mode from intellij? I > >>>>> found > >>>>>>> this <http://visitamaresh.com/debug-solr-cloud-remote-and-local/ > >>>>> [1] > >>>>>>> article which covers what I am looking for but it is from 2015, > >>>> could > >>>>> you > >>>>>>> take a look and verify if all still apply as of today? In that > >>>> article, > >>>>>> are > >>>>>>> the "ant" steps still valid for the current version? > >>>>>>> > >>>>>>> I started by following the steps from making-a-new-contribution > >>>>>>> < > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > >> > https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc#making- > >> a-new-contribution > >> < > https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc#making-a-new-contribution > > > >>>>>>>> > >>>>>>> article > >>>>>>> and finished the first 3 steps. The build was successful. I also > >>>> have > >>>>>> the > >>>>>>> solr setup on intellij and able to run individual tests in debug > >>>> mode. > >>>>>> From > >>>>>>> the article[1], I tried the start command from the bin > >>>>>>> directory(/Users/rajani/projects/solr/solr) and got a class not > >>>> found > >>>>>>> exception "Caused by: org.apache.solr.cli.SolrCLI" Did I miss any > >>>> more > >>>>>>> build steps? Could you please help me with this? > >>>>>>> > >>>>>>> Thank you for looking into this and appreciate your help. > >>>>>>> > >>>>>>> [1] http://visitamaresh.com/debug-solr-cloud-remote-and-local/ > >>>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Sincerely yours > >>>>>> Mikhail Khludnev > >>>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Vincenzo D'Amore > >>>>> > >>>> > >>>> > >>>> -- > >>>> Sincerely yours > >>>> Mikhail Khludnev > >>>> > >>> > >>> > >>> -- > >>> Vincenzo D'Amore > >>> > >>> > >> > >> -- > >> Vincenzo D'Amore > >> > >> > >> > > > > -- > > Vincenzo D'Amore > >
