[SOGo] Webmin SOGo module not honoring changed path to "GNUstep defaults command"

[Christian Kowarzik]

Hi everyone,




The sulution is to patch the sogo-lib.pl:
=> this is for SOGo webmin module named "SOGo server (v. 1.520)"
=> from sogo download page "Webmin SOGo module For SOGo v1.3.6"

--- sogo-lib.pl 2011-02-16 03:00:56.000000000 +0100
+++ sogo-lib-new.pl     2011-04-19 14:12:13.000000000 +0200
@@ -11,7 +11,7 @@
 sub defaults_read
 {
   my $param = shift;

   #warn ('[defaults_read] ' . $cmd);
   my $out = &backquote_logged("$cmd 2>&1 </dev/null", 1);
   my $ex = $?;
@@ -74,7 +74,7 @@
   my $operation = length($value)?"write":"delete";

   my $domain = $config{'gnustep_domain'};

   #warn "$cmd";
   my $out = &backquote_logged("$cmd 2>&1 </dev/null", 1);
   my $ex = $?;
@@ -93,7 +93,7 @@
     }
     push(@params, $buf) if ($buf);
     foreach $param (@params) {
-      $cmd = "defaults -u " . $config{'sogo_user'} . " write " . $param;

       &backquote_logged("$cmd 2>&1 </dev/null", 1);
     }
     warn ('[defaults_write] Backup restored.');


regards,
Christian

the "Full path to GNUstep defaults command" option in the module configuration page is not used by the other module pages (i.e. "General Preferences", "User Source", etc.). So if your "defaults" command is not in the evironment PATH the pages will only show default values, but not your configuration... - my $cmd = "defaults -u " . $config{'sogo_user'} . " read " . $config{'gnustep_domain'} . " " . $param; + my $cmd = $config{'gnustep_defaults_command'} . " -u " . $config{'sogo_user'} . " read " . $config{'gnustep_domain'} . " " . $param; - my $cmd = "defaults -u " . $config{'sogo_user'} . " $operation $domain $param $value"; + my $cmd = $config{'gnustep_defaults_command'} . " -u " . $config{'sogo_user'} . " $operation $domain $param $value"; + $cmd = $config{'gnustep_defaults_command'} . " -u " . $config{'sogo_user'} . " write " . $param;

smime.p7s
Description: S/MIME Cryptographic Signature