Am 11.01.23 um 02:20 schrieb Etienne Gautier:
Hey, I noticed that the images were still not going through email (not sure
Due to some limitation to the ML
what's happening), so instead I created a PR that has all the screenshots
attached in the description, and the proposed change.
Please see the PR here <https://github.com/apache/pdfbox/pull/150> and let
me know if you are interested in merging this change.
Looks like an improvement. The CC0 license is compatible see [1]
I'm ok with replacing the ICC profile with the proposed one.
@Tilman is there any chance to run a test to see if there are any negative side
effects?
Andreas
[1] https://www.apache.org/legal/resolved#handling-public-domain-licensed-works
All the best, Etienne.
On Wed, Jan 11, 2023 at 11:13 AM Etienne Gautier <etie...@canva.com> wrote:
Hello and thanks for getting back quickly,
Hopefully you can see the screenshots now attached (instead of embedded)
to this email.
Thanks for suggesting this workaround, that will solve our problem.
Please have a look at the screenshots and consider using this
<https://github.com/saucecontrol/Compact-ICC-Profiles#cmyk> ICC profile
(under Creative Commons CC0). I think that the visual improvement is pretty
clear, and it would be valuable for other PDFBox users who did not override
the deviceCMYK profile (including those who cannot use USWebCoatedSWOP for
license reasons).
Cheers,
Etienne
On Wed, Jan 11, 2023 at 5:44 AM Tilman Hausherr <thaush...@t-online.de>
wrote:
On 10.01.2023 03:57, Etienne Gautier wrote:
WDYT about changing the deviceCMYK color profile? Or making it
configurable at runtime?
Hi, your images didn't get through. You can use these profiles like this:
//
https://www.adobe.com/support/downloads/iccprofiles/iccprofiles_win.html
PDDeviceCMYK.INSTANCE = new PDDeviceCMYK()
{
@Override
protected ICC_Profile getICCProfile() throws IOException
{
return ICC_Profile.getInstance("USWebCoatedSWOP.icc");
}
};
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: users-h...@pdfbox.apache.org
