There's currently a discussion on the dev list [1] about releasing the next version of the war plugin. I posted there yesterday that this bug should be fixed before a release, you can express your opinion there as well. Additionally, you can vote on the bug report in jira, to make it more visible to the developers that this is an urgent issue for users.

-Tim

[1] http://www.nabble.com/Releasng-the-war-and-deploy-plugins-to17155510.html

Henri Gomez schrieb:
There is a patch provided in http://jira.codehaus.org/browse/MWAR-133.

How can I contact the maintener for a fix ?

2008/5/16 Henri Gomez <[EMAIL PROTECTED]>:
I tested with 2.1-alpha and same problem ;(

2008/5/16 Tim Kettler <[EMAIL PROTECTED]>:
It's a bug in the war plugin. The resource filtering is seriously borked
there, see here [1] for a bug report back from Nov 2007. The obvious and
simple workaround would be to filter web.xml as a normal resource in a
custom invocation of the resource plugin. But unfortunately there is a bug
in the resource plugin as well [2] (open since 2006), causing it to not
recognize a resources element in the plugin configuration.

Sometimes maven is no fun at all :-(

[1] http://jira.codehaus.org/browse/MWAR-133
[2] http://jira.codehaus.org/browse/MRESOURCES-8

Henri Gomez schrieb:
I suspect something weird in maven-war plugin (2.0.2) since I get the
same error from m2eclipse which use maven 2.1 embedded

2008/5/16 Henri Gomez <[EMAIL PROTECTED]>:
*.version => pom.version

*.name => pom.name

2008/5/16 Henri Gomez <[EMAIL PROTECTED]>:
Problem in maven-war 2.0.2 or in maven 2.0.9 ?

2008/5/16 Tim Kettler <[EMAIL PROTECTED]>:
Strange, indeed.

Looks like a bug to me. I tried with this in web.xml and no filter
property
files:

 pom.name: ${pom.name}
 user.name: ${user.name}
 name: ${name}
 foo.name: ${foo.name}

 pom.version: ${pom.version}
 os.version: ${os.version}
 version: ${version}
 foo.version: ${foo.version}

And the filtered result is this:

 pom.name: servlet
 user.name: servlet
 name: servlet
 foo.name: servlet

 pom.version: 1.0
 os.version: 1.0
 version: 1.0
 foo.version: 1.0

It seems that the system properties get somehow shadowed by the
standard pom
properties. This seems to be the case even for custom properties like
foo.version that are not defined anywhere.

-Tim

Henri Gomez schrieb:
Strange.

I could get thru filter ${user.home} or ${java.version} but not
${user.name}

Any idea ?

2008/5/16 Henri Gomez <[EMAIL PROTECTED]>:
Many thanks Tim.

I was using the same thing, excepted <targetPath>WEB-INF</targetPath>

It works now !

2008/5/16 Tim Kettler <[EMAIL PROTECTED]>:
Hi,

I do it like this:

 <build>
 <plugins>
   <plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-war-plugin</artifactId>
     <configuration>
       <webResources>
         <webResource>
           <directory>${basedir}/src/main/webapp/WEB-INF</directory>
           <includes>
             <include>web.xml</include>
           </includes>
           <targetPath>WEB-INF</targetPath>
           <filtering>true</filtering>
         </webResource>
       </webResources>
     </configuration>
   </plugin>
 </plugins>
 </build>

and I think this is the right way to do it since standard resources
end
up
somewhere under 'target/classes' and I don't want that polluted with
a
web.xml file.

-Tim

Henri Gomez schrieb:
Hi to all,

In a war project I'd like to filter the
src/main/webapp/WEB-INF/web.xml
:

ie : update the display name to include the pom version

     <display-name>My Site Application
v${pom.version}</display-name>

I read some threads and it's not clear if it should be done by
web-resources or standard filtering.

ie :


http://www.nabble.com/War-plugin-and-filtering-webapp-files-to4384723.html


Advice welcome, I'm using maven-war-plugin 2.0.2

regards and thanks for your help, I'm being crasy :)


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to