Now the patches are attached, my apologies..
René
* René Clerc <[EMAIL PROTECTED]> [24-03-2006 09:37]:
> Hi,
>
> * eastwoj <[EMAIL PROTECTED]> [24-03-2006 05:36]:
>
> > 1) Running the maven tomcat:deploy goal, plugin.jelly file for
> > maven-tomcat-plugin 1.2.1 does not seem to be recognizing that i've set
> > maven.tomcat.deploy.mode=development. I can echo the correct value to the
> > console, but the "if test" ( <j:if test="${maven.tomcat.deploy.mode ==
> > 'development'}">) still fails.
>
> I have encountered this problem too, and solved it. The tests seem to
> fail because the way in which the variables are read is not correct.
>
> Attached patch fixes this problem, at least for the tomcat:deploy and
> tomcat:undeploy goals.
>
> > 2) if i force it to pass by setting it to <j:if test="${true}">,(
> > temporarily ignoring problem #1 ), i get a BUILD FAILED error,
> > org/apache/tools/ant/taskdefs/Redirector
>
> Out-of-the-box, the plugin depends on tomcat 5.5.12. I have changed
> the dependencies of the plugin to depend on 5.5.15 (which you use
> too), and found that I needed to add a dependency on ant. See
> attached patch.
>
> How to apply:
>
> unjar the plugin
> apply the patch(es)
> rejar the plugin
>
> You might want to use a slightly different version number, to
> distinguish your modified version from the standard 1.2.1 version.
>
> If convenient, I can supply a modified jar file, but I'm not going to
> post this to the list.
>
> Oh, by the way, I have e-mailed codeczar support about this problem,
> but to no avail.. Now cc-ing the developer.
>
> Hope this helps,
>
> --
> René Clerc - ([EMAIL PROTECTED]) - PGP: 0x9ACE0AC7
>
> 42. When I capture the hero, I will make sure I also get his dog,
> monkey, ferret, or whatever sickeningly cute little animal capable
> of untying ropes and filching keys happens to follow him around.
>
> -"Peter Anspach's list of things to do as an Evil Overlord"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
René Clerc - ([EMAIL PROTECTED]) - PGP: 0x9ACE0AC7
153. My Legions of Terror will be an equal-opportunity employer.
Conversely, when it is prophesied that no man can defeat me, I will
keep in mind the increasing number of non-traditional gender roles.
-"Peter Anspach's list of things to do as an Evil Overlord"
--- maven-tomcat-plugin/plugin.jelly 2006-03-23 16:35:16.000000000 +0100
+++ test/plugin.jelly 2006-03-23 15:38:55.000000000 +0100
@@ -101,7 +101,7 @@
<echo message="ctx '${ctx}'
file:${maven.build.dir}/${maven.war.final.name}"/>
- <j:if test="${maven.tomcat.deploy.mode == 'live'}">
+ <j:if test="${context.getVariable('maven.tomcat.deploy.mode') ==
'live'}">
<echo message="deploying in live mode"/>
<deploy url="${maven.tomcat.manager.url}"
username="${maven.tomcat.username}"
@@ -109,7 +109,7 @@
war="file:${maven.build.dir}/${maven.war.final.name}"
path="${ctx}"/>
</j:if>
- <j:if test="${maven.tomcat.deploy.mode == 'development'}">
+ <j:if test="${context.getVariable('maven.tomcat.deploy.mode') ==
'development'}">
<echo message="deploying in development mode"/>
<j:set var="maven.target.ctx.file"
value="${maven.war.webapp.dir}/META-INF/context.xml"/>
@@ -156,7 +156,7 @@
prereqs="tomcat:init">
<j:choose>
- <j:when test="${maven.tomcat.deploy.mode == 'live'}">
+ <j:when test="${context.getVariable('maven.tomcat.deploy.mode')
== 'live'}">
<attainGoal name="tomcat:_update"/>
</j:when>
<j:otherwise>
--- maven-tomcat-plugin/project.xml 2006-03-23 16:35:16.000000000 +0100
+++ test/project.xml 2006-03-23 16:20:28.000000000 +0100
@@ -74,15 +74,23 @@
<dependency>
<groupId>tomcat</groupId>
<artifactId>catalina-ant</artifactId>
- <version>5.5.12</version>
+ <version>5.5.15</version>
+ <properties>
+ <classloader>root</classloader>
+ </properties>
+ </dependency>
+ <dependency>
+ <groupId>ant</groupId>
+ <artifactId>ant</artifactId>
+ <version>1.6.5</version>
<properties>
<classloader>root</classloader>
</properties>
</dependency>
<dependency>
<groupId>tomcat</groupId>
- <artifactId>catalina-deployer</artifactId>
- <version>5.5.12</version>
+ <artifactId>catalina</artifactId>
+ <version>5.5.15</version>
<properties>
<classloader>root</classloader>
</properties>
@@ -103,7 +111,7 @@
<dependency>
<groupId>tomcat</groupId>
<artifactId>jasper-compiler</artifactId>
- <version>5.5.12</version>
+ <version>5.5.15</version>
<properties>
<classloader>root</classloader>
</properties>
@@ -111,7 +119,7 @@
<dependency>
<groupId>tomcat</groupId>
<artifactId>jasper-runtime</artifactId>
- <version>5.5.12</version>
+ <version>5.5.15</version>
<properties>
<classloader>root</classloader>
</properties>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
