Jim N schrieb am 16.05.2021 18:27 (GMT +07:00): > im not sure whether the prior response fully bounced, so forgive the > duplication: > > This is the maven users list not the shade issues tracker. expect > helpful suggestions that don't share your viewpoints or goals.
Looks like it did, I did not get anything of that sort before in this thread. Now I know what you are talking about. Actually, I open issues if I think I found a bug or a usability problem, not for general inquiries about a plugin's behaviour. The latter is what my question is about. Sorry if this is off-topic here. Shade is a core Maven plugin, so I thought it was appropriate to ask here. If I would have gotten an answer like "this sounds weird and should not happen, please open a ticket with a reproducible example" or "this is to be expected, because Shade also re-writes classes it does not relocate", then I would have known what to do next and whether to just feel good about the current behaviour or to open an issue in the tracker. ------------------------------------------------------------------------ Now for the off-topic stuff (sorry to everyone, but I did not start this): > I'd suggest you find the shade plugin source code and resist the urge > to mix words like "horrible" with responses that lack grattitude. I did not say "horrible" in this thread. I used the term a while ago in a completely different topic, this one is unrelated. And I used it, because someone (don't remember who) suggested, to just not use any Maven pluging but script my build. Sorry if I feel somewhat strongly about this topic on a mailing list where other people get scolded for doing things not the "Maven way" and for actually believing in the "Maven way" myself. Furthermore, in that other thread in my question I already explained that I have a working Maven solution, but just feel it is awkward and explicitly asked for a *more canonical* one, not a less canonical one. > FYI To unsubscribe, e-mail: users-unsubscr...@maven.apache.org Why are you being sarcastic and condescending? Did I abuse you in a previous life? I do not wish to unsubscribe. I am happy to be here. Sometimes I answer someone's question, sometimes I am asking one. > On Sun, May 16, 2021 at 6:55 PM Alexander Kriegischwrote: >> >> I have no idea what you are talking about and how your answer >> concerning "non-relocating options" is relevant to my question about >> the opposite. I also did not report any surprises during my >> deployments or runtime behaviour of relocated classes. Thanks for >> your feedback anyway. Next time, maybe try to contribute a >> constructive answer instead of a destructive comment, or refrain from >> replying at all. I would be much obliged. The way you replied sounds >> just enigmatic at best, lecturing trying to make me feel stupid >> otherwise. Not helpful! >> >> >>> You might want to examine the "horrible" Non relocating options >>> previously outlined if you want a fast resolution to unsurprising >>> deployments. >>> >>> >>> On Sun, May 16, 2021, 10:41 AM Alexander Kriegisch wrote: >>> >>>> When running Maven Shade with relocation, it works nicely. When >>>> comparing JARs before and after relocation, I was surprised to see >>>> that Shade not just modifies the relocated classes and classes >>>> referencing them, but also a bunch of IMO completely unrelated >>>> classes. In my case I am transforming an uber JAR containing ASM, >>>> and I selectively relocate the ASM classes, intending to leave all >>>> others untouched. I know that ASM classes are referred to by some >>>> of the other classes, but by no means as many as are being >>>> modified. The byte code is slightly different, probably still does >>>> the same thing, but it makes comparisons and sanity checks or >>>> automatic verification steps harder than necessary. BTW, the same >>>> Shade execution also relocates the sources and really only changes >>>> source files referencing ASM, just like I would have expected. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
