Great, let's continue at dev@ and its PR On Mon, Nov 9, 2015 at 11:50 PM, Sebastian Schaffert < sebastian.schaff...@gmail.com> wrote:
> Hi Mark, > > thanks for the work, this looks really interesting. I'll have a look in > the coming days (the locking is a bit intricate). > > Cheers, > > Sebastian > > 2015-11-09 22:32 GMT+01:00 Mark Triggs <m...@dishevelled.net>: > >> Hi Sergio, >> >> Sergio Fernández <wik...@apache.org> writes: >> >> Hi Mark, >> >> On Mon, Nov 9, 2015 at 5:42 AM, Mark Triggs <m...@dishevelled.net> wrote: >> >> I've got a patch for this that I'm happy to send along. I drop the lock >> >> prior to running the getTripleId() query (allowing multiple connections >> to run the query at once), then only take it again if I need to write a new >> triple ID to the registry: >> >> >> https://github.com/marktriggs/marmotta/blob/mst-perf/libraries/kiwi/kiwi-triplestore/src/main/java/org/apache/marmotta/kiwi/sail/KiWiValueFactory.java#L578 >> >> Cool! In principle the refactoring in the lock strategy sounds good for >> me. >> >> Then please: first register an issue in our jira, and then create a PR >> with out patch using the issue key in the name. We'll discuss the patch in >> dev@marmotta, so please join that mailing list for >> >> Thanks! I've just created MARMOTTA-620 and have sent a pull request >> along. I'm now on the dev list too, so will keep an eye out for any >> discussion. >> >> Cheers, >> >> Mark >> >> -- >> Mark Triggs >> <m...@dishevelled.net> >> >> > -- Sergio Fernández Partner Technology Manager Redlink GmbH m: +43 6602747925 e: sergio.fernan...@redlink.co w: http://redlink.co
