You're absolutely right. Thanks for the patch, I applied it on the trunk (revision 16560).

  Thanks,
    george.

On Oct 24, 2007, at 8:17 AM, Åke Sandgren wrote:

On Wed, 2007-10-24 at 09:00 +0200, Åke Sandgren wrote:
Hi!

In common_mx.c the following looks wrong.
ompi_common_mx_finalize(void)
{
    mx_return_t mx_return;
    ompi_common_mx_initialize_ref_cnt--;
    if(ompi_common_mx_initialize == 0) {

That should be
if(ompi_common_mx_initialize_ref_cnt == 0)
right?


And there was a missing return too.
Complete ompi_common_mx_finalize should be
int
ompi_common_mx_finalize(void)
{
    mx_return_t mx_return;
    ompi_common_mx_initialize_ref_cnt--;
    if(ompi_common_mx_initialize_ref_cnt == 0) {
        mx_return = mx_finalize();
        if(mx_return != MX_SUCCESS){
            opal_output(0, "Error in mx_finalize (error %s)\n",
mx_strerror(mx_return));
            return OMPI_ERROR;
        }
    }
    return OMPI_SUCCESS;
}


_______________________________________________
users mailing list
us...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/users

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to