Barry, Thanks very much again for this!
On Mon Dec01'25 11:18:18AM, Barry Scott wrote: > > > > > On 30 Nov 2025, at 19:13, Ranjan Maitra via users > > <[email protected]> wrote: > >>> I am the package maintainer of SLiM, the Simple Login Manager. While > >>> trying to take care of an automated BZ request, I decided to look into > >>> also updating the package. > >>> > >>> Because upstream is not very responsive, as the author is sadly > >>> indisposed for the long-term, I moved the code to github at > >>> https://github.com/maitra/slim-fork after having made some of the > >>> corrections (suggested earlier here) which make the package compile > >>> without error. And also bumped up the cmakeminimum which is what > >>> triggered the BZ request. > >>> > Don't think you need this: > > BuildRequires: systemd > > Or xterm > > BuildRequires: scrot xterm freeglut-devel libXrandr-devel > > The rest seems okay at first glance. THanks, there is some reason I needed these, which I do not recall right now, but let us leave it in for now. > > I personally put each BuildRequire item on its own line. > Then when you add or remove a BUildRequire its a one line change in diff. > Having multiple items per line makes git diff harder to read in my opinion. Excellent point, thanks! I uploaded the lightly edited SPEC file here: Uploading (20.3KiB)... https://paste.centos.org/view/94a26022 THe errors obviously have not changed, and are at: Uploading (83.8KiB)... https://paste.centos.org/view/9b28fe9d > This is the important part of the errors. > > In file included from > /home/localuser/rpmbuild/BUILD/slim-fork-1.4.2-build/slim-fork-1.4.2/app.cpp:31: > /home/localuser/rpmbuild/BUILD/slim-fork-2.4.2-build/slim-fork-1.4.2/log.h: > In instantiation of ‘LogUnit& LogUnit::operator<<(const Type&) [with Type = > PAM::Exception]’: > > /home/localuser/rpmbuild/BUILD/slim-fork-2.4.2-build/slim-fork-1.4.2/app.cpp:331:35: > required from here > 330 | logStream << APPNAME << ": " << e << endl; > | ^ > > /home/localuser/rpmbuild/BUILD/slim-fork-2.4.2-build/slim-fork-1.4.2/log.h:34:25: > error: no match for ‘operator<<’ (operand types are ‘std::ostream’ {aka > ‘std::basic_ostream<char>’} and ‘const PAM::Exception’) > 33 | *logOut << text; logOut->flush(); > | ~~~~~~~~^~~~~~~ > > You are missing the definition of operator<<(const PAM::Exception) - I think. > > If you see it build sometimes that suggests that cmake is auto configuring to > use different header files > in the case of things build vs. when they fail. > So, this is perplexing to me. I see: std::ostream& operator<<( std::ostream& os, const PAM::Exception& e); in PAM.h and that is being called in app.h and PAM.h in the BUILD directory. Is this not enough? Strangely, the 1.4.0 build has no problems with this, as well as building it outside the RPM environment being created with the SPEC file. > You can use `mock` locally to test your srpm works in a clean environment. > See `man mock` for command line options. But do I not need a SRPM for that? Right now rpmbuild -ba does not exit with a SRPM. (THe errors above show up here too.) > > This will eliminate issues with RPMs you do or do not have installed on your > system > that change the build. > > Once you have a SRPM then you could build it in the copr service. > You can only use koji if you are a fedora packager. Yes, I am a fedora packager and have an account. I largely package files that are retired and orphaned but can not let go of :-( Anyway, thanks again for all your thoughts and suggestions. Best wishes, Ranjan -- _______________________________________________ users mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
