Ranjan Maitra via users wrote: > Todd, > > Thank you for this! > > On Sat May31'25 04:18:49PM, Todd Zullinger wrote: >> I know nothing about slim, but that seems like a problem. >> The package does include /var/run/slim and has a >> tmpfiles.d config which should recreate it on boot, but >> perhaps it is missing. If not, whatever creates >> slim.auth seems amiss. > > Thanks, interesting, but I checked and the same error also > shows up on the F41 box (and does not seem to create an X > "problem"). And there is no slim.auth (on F41) anywhere. > Perhaps things have become stricter and needs to be fixed > (from F42 onwards).
Maybe, but if it just reports a spurious error, that makes me think it's something else. It's also why I don't like ignorable errors. :) > The version on slim is slim-1.4.0-10.fc42 on F42 and > slim-1.4.0-9.fc41 on F41. I did not think that the last > numeral mattered much. That greatly depends. That form is NAME-VERSION-RELEASE, where VERSION is the upstream version and release is the number of revisions or releases of that package. Anytime changes are made to the packaging, the release in bumped. That might be for nothing more than a rebuild or it could be a large change to the spec file. You have to look at the rpm changelog and/or the packages git history to determine whether it's a trivial change or not. >> warnings (if nothing else). > > I see, the spec file appears to have the following: > > * Wed Jun 01 2011 Jan Kaluza <jkal...@redhat.com> - 1.3.2-6 > - fix #708693 - added tmfiles.d config to create /var/run/slim directory >> That's really more of problem for the upstream and/or >> Fedora maintainers, but any interested users could submit >> a patch to correct this either upstream or to Fedora's >> package. > > OK, I am embarrassed to say that I think I am the Fedora > maintainer (from the retired original package but did not > receive email about the updated version). Hah! So you are. Hopefully that will help if you find the package requires some fiddling to fix this issue. :) > But what is the change that I need to do in the spec file > to get the /var/run changed to /run? > > I have posted the slim.spec that I have here: > https://paste.centos.org/view/c6952de4 > > (I was actually under the impression that packaging tools > took care of such things automatically.) Over time, things change and require adaptations in the spec files. /var/run is now a symlink to /run. In the past, it was the opposite. When systemd starts a service and notices /var/run for the pid file, it logs a warning that you should change it. Whether that is something you feel is important for the package, I don't know. Attached is a patch (entirely untested) showing one way to do it (which includes some whitespace cleanups in the immediately surrounding lines). I used the %{_runstatedir} macro rather than hard-coded /run. Not everyone bothers with that, particularly when it seems unlikely to change and more so when the macro is so much longer. Using the macro also means generating the tmpfiles.d config in the spec rather than keeping it separate. That's another matter of taste and style which can be argued either way. I based it directly from the Fedora slim git repo, which is a number of revisions ahead of the one you pasted. The only changes are the release bumps for rebuilds with Fedora 39-42, so it doesn't affect the patch context. -- Todd
diff --git c/slim-tmpfiles.conf i/slim-tmpfiles.conf
deleted file mode 100644
index 8ccb38b..0000000
--- c/slim-tmpfiles.conf
+++ /dev/null
@@ -1 +0,0 @@
-d /var/run/slim
diff --git c/slim.spec i/slim.spec
index d599859..329fb7e 100644
--- c/slim.spec
+++ i/slim.spec
@@ -15,9 +15,8 @@ Source3: slim-dynwm
Source4: slim-fedora.txt
# logrotate entry (see bz#573743)
Source5: slim.logrotate.d
-Source6: slim-tmpfiles.conf
-Source7: slim.service
-patch0: slim-1.4.0-fedora.patch
+Source6: slim.service
+patch0: slim-1.4.0-fedora.patch
patch1: slim-1.4.0-selinux.patch
## Keyring copied on 2023-02-26 from: xfontsel.gpg
@@ -84,16 +83,17 @@ install -p -m755 %{SOURCE3}
%{buildroot}%{_bindir}/%{name}-dynwm
chmod 0644 %{buildroot}%{_sysconfdir}/%{name}.conf
install -d -m755 %{buildroot}%{_sysconfdir}/pam.d
install -p -m644 %{SOURCE1} %{buildroot}%{_sysconfdir}/pam.d/%{name}
-mkdir -p %{buildroot}%{_localstatedir}/run/%{name}
+mkdir -p %{buildroot}%{_runstatedir}/%{name}
rm -f %{buildroot}%{_datadir}/%{name}/themes/default/background.jpg
ln -s ../../../backgrounds/f%{?fedora}/default/f%{?fedora}-01-day.png
%{buildroot}%{_datadir}/%{name}/themes/default/background.png
# install logrotate entry
install -m0644 -D %{SOURCE5} %{buildroot}/%{_sysconfdir}/logrotate.d/%{name}
-install -p -D %{SOURCE6} %{buildroot}%{_sysconfdir}/tmpfiles.d/%{name}.conf
+mkdir -p %{buildroot}%{_sysconfdir}/tmpfiles.d
+echo "d %{_runstatedir}/%{name}"
>%{buildroot}%{_sysconfdir}/tmpfiles.d/%{name}.conf
mkdir -p %{buildroot}%{_unitdir}
-install -m 644 %{SOURCE7} %{buildroot}%{_unitdir}/%{name}.service
+install -m 644 %{SOURCE6} %{buildroot}%{_unitdir}/%{name}.service
# Fix lib dir according to bits of system
mkdir -p %{buildroot}/%{_libdir}/
@@ -118,7 +118,7 @@ mkdir -p %{buildroot}/%{_libdir}/
%config(noreplace) %verify(not size mtime md5) %{_sysconfdir}/pam.d/%{name}
%config(noreplace) %verify(not size mtime md5) %{_sysconfdir}/%{name}.conf
%config(noreplace) %verify(not size mtime md5)
%{_sysconfdir}/logrotate.d/%{name}
-%ghost %dir %{_localstatedir}/run/%{name}
+%ghost %dir %{_runstatedir}/%{name}
%{_bindir}/%{name}*
%{_bindir}/update_slim_wmlist
%{_mandir}/man1/%{name}*.1*
signature.asc
Description: PGP signature
-- _______________________________________________ users mailing list -- users@lists.fedoraproject.org To unsubscribe send an email to users-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/users@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
