On 08May2020 11:15, Robert Moskowitz <r...@htt-consult.com> wrote:
I added inserting a Date: line and switched to using sed:

local]# cat mycron
#!/bin/sh

currentDate="$(date +'%a %b %d %T %Y')"

You don't need the double quotes. The shell parser recognises the assignment statement _before_ breaking things on whitespace.

echo "From cron@localhostĀ  $currentDate" >> /var/spool/mail/$USER
currentDate="$(date +'%a,%e %b %Y %T %z (%Z)')"

Again, double quotes not needed.

sed "/^Status:/a Date: $currentDate" >> /var/spool/mail/$USER

You can just use echo; the Date: header does not need to be in a specific position.

echo "" >> /var/spool/mail/$USER

You do a lot of explicit >>mailfile. Try this:

   exec 3>>"/var/spool/mail/$USER"
   ... script ...

and just put ">&3" instead of ">>/var/spool/mail/$USER".

More readable, avoids typos, avoids gratiuitous extra opening of the mail file per command.

Cheers,
Cameron Simpson <c...@cskk.id.au>
_______________________________________________
users mailing list -- users@lists.fedoraproject.org
To unsubscribe send an email to users-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/users@lists.fedoraproject.org

Reply via email to