Hi Mickael, I did the following checks:
- Signature, checksum, licenses
- Build from source with Java 17 and Scala 2.13
- Full unit and integration test suites
- Java app with staging Maven artifacts and multi-node cluster
LGTM, apart from the already mentioned "classgraph" license that can be removed.
+1 (non binding)
Thanks
Fede
On Tue, Jun 6, 2023 at 9:39 AM Luke Chen <show...@gmail.com> wrote:
>
> Hi Mickael,
>
> I ran the following validation steps:
> - Built from source with Java 17 and Scala 2.13
> - Signatures and hashes of the artifacts generated
> - Navigated through Javadoc including links to JDK classes
> - Run the quickstart in KRaft and Zookeeper mode
>
> +1 (binding) from me.
> Thanks for running the release.
>
> Luke
>
> On Tue, Jun 6, 2023 at 4:23 AM Josep Prat <josep.p...@aiven.io.invalid>
> wrote:
>
> > Hi Mickael,
> >
> > I ran the following validation steps:
> > - Built from source with Java 11 and Scala 2.13
> > - Signatures and hashes of the artifacts generated
> > - Navigated through Javadoc including links to JDK classes
> > - Run the unit tests
> > - Run integration tests
> > - Run the quickstart in KRaft and Zookeeper mode
> > -- For KRaft, I looked at the process running Kafka and confirmed that the
> > spamming log message is not present anymore ("Generated a metadata delta
> > between...")
> > - Checked the contents of LICENSE-binary against the lib folder
> > -- I found that the LICENSE-binary has a reference to classgraph-4.8.138
> > but I fail to find this library in the lib folder. Trying to backtrack when
> > it was added, it seems it was done here:
> >
> > https://github.com/apache/kafka/commit/3a2ac267178c5464e41b94fcbb2dd897212812bd
> > but I fail to find this library in the 3.3.1 lib folder (3.3.0 was a dead
> > release).
> >
> > I'm not sure this qualifies as a blocker for the release though, I leave it
> > up to you.
> >
> > Best,
> >
> > On Mon, Jun 5, 2023 at 3:39 PM Mickael Maison <mimai...@apache.org> wrote:
> >
> > > Hello Kafka users, developers and client-developers,
> > >
> > > This is the second candidate for release of Apache Kafka 3.5.0. Some
> > > of the major features include:
> > > - KIP-710: Full support for distributed mode in dedicated MirrorMaker
> > > 2.0 clusters
> > > - KIP-881: Rack-aware Partition Assignment for Kafka Consumers
> > > - KIP-887: Add ConfigProvider to make use of environment variables
> > > - KIP-889: Versioned State Stores
> > > - KIP-894: Use incrementalAlterConfig for syncing topic configurations
> > > - KIP-900: KRaft kafka-storage.sh API additions to support SCRAM for
> > > Kafka Brokers
> > >
> > > Release notes for the 3.5.0 release:
> > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/RELEASE_NOTES.html
> > >
> > > *** Please download, test and vote by Friday June 9, 5pm PT
> > >
> > > Kafka's KEYS file containing PGP keys we use to sign the release:
> > > https://kafka.apache.org/KEYS
> > >
> > > * Release artifacts to be voted upon (source and binary):
> > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/
> > >
> > > * Maven artifacts to be voted upon:
> > > https://repository.apache.org/content/groups/staging/org/apache/kafka/
> > >
> > > * Javadoc:
> > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/javadoc/
> > >
> > > * Tag to be voted upon (off 3.5 branch) is the 3.5.0 tag:
> > > https://github.com/apache/kafka/releases/tag/3.5.0-rc1
> > >
> > > * Documentation:
> > > https://kafka.apache.org/35/documentation.html
> > >
> > > * Protocol:
> > > https://kafka.apache.org/35/protocol.html
> > >
> > > * Successful Jenkins builds for the 3.5 branch:
> > > Unit/integration tests: I'm struggling to get all tests to pass in the
> > > same build. I'll run a few more builds to ensure each test pass at
> > > least once in the CI. All tests passed locally.
> > > System tests: The build is still running, I'll send an update once I
> > > have the results.
> > >
> > > Thanks,
> > > Mickael
> > >
> >
> >
> > --
> > [image: Aiven] <https://www.aiven.io>
> >
> > *Josep Prat*
> > Open Source Engineering Director, *Aiven*
> > josep.p...@aiven.io | +491715557497
> > aiven.io <https://www.aiven.io> | <https://www.facebook.com/aivencloud
> > >
> > <https://www.linkedin.com/company/aiven/> <
> > https://twitter.com/aiven_io>
> > *Aiven Deutschland GmbH*
> > Alexanderufer 3-7, 10117 Berlin
> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> > Amtsgericht Charlottenburg, HRB 209739 B
> >
