In other words, I think the default should be the exact behavior we have today plus the remaining group information from DescribeGroupResponse.
On Fri, Jul 14, 2017 at 11:36 AM, Onur Karaman <onurkaraman.apa...@gmail.com > wrote: > I think if we had the opportunity to start from scratch, --describe would > have been the following: > --describe --offsets: shows all offsets committed for the group as well as > lag > --describe --state (or maybe --members): shows the full > DescribeGroupResponse output (including things like generation id, state, > protocol type, etc) > --describe: shows the merged version of the above two. > > On Fri, Jul 14, 2017 at 10:56 AM, Jason Gustafson <ja...@confluent.io> > wrote: > >> Hey Vahid, >> >> Thanks for the KIP. Looks like a nice improvement. One minor suggestion: >> Since consumers can be subscribed to a large number of topics, I'm >> wondering if it might be better to leave out the topic list from the >> "describe members" option so that the output remains concise? Perhaps we >> could list only the number of assigned partitions so that users have an >> easy way to check the overall balance and we can add a separate "describe >> topics" switch to see the topic breakdown? >> >> As for the default --describe, it seems safest to keep its current >> behavior. In other words, we should list all partitions which have >> committed offsets for the group even if the partition is not currently >> assigned. However, I don't think we need to try and fit members without >> any >> assigned partitions into that view. >> >> Thanks, >> Jason >> >> On Fri, Jul 7, 2017 at 10:49 AM, Vahid S Hashemian < >> vahidhashem...@us.ibm.com> wrote: >> >> > Thanks Jeff for your feedback on the usefulness of the current tool. >> > >> > --Vahid >> > >> > >> > >> > >> > From: Jeff Widman <j...@netskope.com> >> > To: d...@kafka.apache.org >> > Cc: Kafka User <users@kafka.apache.org> >> > Date: 07/06/2017 02:25 PM >> > Subject: Re: [DISCUSS] KIP-175: Additional '--describe' views for >> > ConsumerGroupCommand >> > >> > >> > >> > Thanks for the KIP Vahid. I think it'd be useful to have these filters. >> > >> > That said, I also agree with Edo. >> > >> > We don't currently rely on the output, but there's been more than one >> time >> > when debugging an issue that I notice something amiss when I see all the >> > data at once but if it wasn't present in the default view I probably >> would >> > have missed it as I wouldn't have thought to look at that particular >> > filter. >> > >> > This would also be more consistent with the API of the kafka-topics.sh >> > where "--describe" gives everything and then can be filtered down. >> > >> > >> > >> > On Tue, Jul 4, 2017 at 10:42 AM, Edoardo Comar <eco...@uk.ibm.com> >> wrote: >> > >> > > Hi Vahid, >> > > no we are not relying on parsing the current output. >> > > >> > > I just thought that keeping the full output isn't necessarily that bad >> > as >> > > it shows some sort of history of how a group was used. >> > > >> > > ciao >> > > Edo >> > > -------------------------------------------------- >> > > >> > > Edoardo Comar >> > > >> > > IBM Message Hub >> > > >> > > IBM UK Ltd, Hursley Park, SO21 2JN >> > > >> > > "Vahid S Hashemian" <vahidhashem...@us.ibm.com> wrote on 04/07/2017 >> > > 17:11:43: >> > > >> > > > From: "Vahid S Hashemian" <vahidhashem...@us.ibm.com> >> > > > To: d...@kafka.apache.org >> > > > Cc: "Kafka User" <users@kafka.apache.org> >> > > > Date: 04/07/2017 17:12 >> > > > Subject: Re: [DISCUSS] KIP-175: Additional '--describe' views for >> > > > ConsumerGroupCommand >> > > > >> > > > Hi Edo, >> > > > >> > > > Thanks for reviewing the KIP. >> > > > >> > > > Modifying the default behavior of `--describe` was suggested in the >> > > > related JIRA. >> > > > We could poll the community to see whether they go for that option, >> > or, >> > > as >> > > > you suggested, introducing a new `--only-xxx` ( can't also think of >> a >> > > > proper name right now :) ) option instead. >> > > > >> > > > Are you making use of the current `--describe` output and relying on >> > the >> > > >> > > > full data set? >> > > > >> > > > Thanks. >> > > > --Vahid >> > > > >> > > > >> > > > >> > > > >> > > > From: Edoardo Comar <eco...@uk.ibm.com> >> > > > To: d...@kafka.apache.org >> > > > Cc: "Kafka User" <users@kafka.apache.org> >> > > > Date: 07/04/2017 03:17 AM >> > > > Subject: Re: [DISCUSS] KIP-175: Additional '--describe' views >> > for >> > > >> > > > ConsumerGroupCommand >> > > > >> > > > >> > > > >> > > > Thanks Vahid, I like the KIP. >> > > > >> > > > One question - could we keep the current "--describe" behavior >> > unchanged >> > > >> > > > and introduce "--only-xxx" options to filter down the full output as >> > you >> > > >> > > > proposed ? >> > > > >> > > > ciao, >> > > > Edo >> > > > -------------------------------------------------- >> > > > >> > > > Edoardo Comar >> > > > >> > > > IBM Message Hub >> > > > >> > > > IBM UK Ltd, Hursley Park, SO21 2JN >> > > > >> > > > >> > > > >> > > > From: "Vahid S Hashemian" <vahidhashem...@us.ibm.com> >> > > > To: dev <d...@kafka.apache.org>, "Kafka User" >> > > <users@kafka.apache.org> >> > > > Date: 04/07/2017 00:06 >> > > > Subject: [DISCUSS] KIP-175: Additional '--describe' views for >> > > > ConsumerGroupCommand >> > > > >> > > > >> > > > >> > > > Hi, >> > > > >> > > > I created KIP-175 to make some improvements to the >> > ConsumerGroupCommand >> > > > tool. >> > > > The KIP can be found here: >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-175%3A >> > > > +Additional+%27--describe%27+views+for+ConsumerGroupCommand >> > > > >> > > > >> > > > >> > > > Your review and feedback is welcome! >> > > > >> > > > Thanks. >> > > > --Vahid >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > Unless stated otherwise above: >> > > > IBM United Kingdom Limited - Registered in England and Wales with >> > number >> > > >> > > > 741598. >> > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire >> PO6 >> > > 3AU >> > > > >> > > > >> > > > >> > > > >> > > >> > > Unless stated otherwise above: >> > > IBM United Kingdom Limited - Registered in England and Wales with >> number >> > > 741598. >> > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 >> > 3AU >> > > >> > >> > >> > >> > >> > >> > >
