Sure, that sounds good. I suggested that to keep command line behavior consistent. Plus, removal of ACL access is something that can be easily undone, but topic deletion is not reversible. So, perhaps a new follow-up JIRA to this KIP to add the confirmation for topic deletion.
Thanks. --Vahid From: Gwen Shapira <g...@confluent.io> To: d...@kafka.apache.org, users@kafka.apache.org Date: 05/27/2017 11:04 AM Subject: Re: KIP-162: Enable topic deletion by default Thanks Vahid, Do you mind if we leave the command-line out of scope for this? I can see why adding confirmations, options to bypass confirmations, etc would be an improvement. However, I've seen no complaints about the current behavior of the command-line and the KIP doesn't change it at all. So I'd rather address things separately. Gwen On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian <vahidhashem...@us.ibm.com> wrote: > Gwen, thanks for the KIP. > It looks good to me. > > Just a minor suggestion: It would be great if the command asks for a > confirmation (y/n) before deleting the topic (similar to how removing ACLs > works). > > Thanks. > --Vahid > > > > From: Gwen Shapira <g...@confluent.io> > To: "d...@kafka.apache.org" <d...@kafka.apache.org>, Users > <users@kafka.apache.org> > Date: 05/26/2017 07:04 AM > Subject: KIP-162: Enable topic deletion by default > > > > Hi Kafka developers, users and friends, > > I've added a KIP to improve our out-of-the-box usability a bit: > KIP-162: Enable topic deletion by default: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default > > > Pretty simple :) Discussion and feedback are welcome. > > Gwen > > > > >
