Hi Steven, Thanks for the KIP. I think this is a worthy addition to the API.
Thanks, Damian On Tue, 7 Feb 2017 at 09:30 Eno Thereska <eno.there...@gmail.com> wrote: > Hi, > > I like the proposal, thank you. I have found it frustrating myself not to > be able to understand simple things, like how many records have been > currently processed. The peek method would allow those kinds of diagnostics > and debugging. > > Gwen, it is possible to do this with the existing functionality like map, > but you'd have to fake the map method. Also, it is not great using map for > things it was not intended for. Having an explicit peek makes it clearer in > my opinion. > > Thanks > Eno > > > On 7 Feb 2017, at 03:20, Gwen Shapira <g...@confluent.io> wrote: > > > > I've read the wiki and am unclear about the proposal. Can you provide > > something like a Javadoc for peek()? What would this method do? > > > > Also, forgive me if I'm missing an important point here, but can't I > > put the println statement in a map()? > > > > On Mon, Feb 6, 2017 at 5:48 PM, Matthias J. Sax <matth...@confluent.io> > wrote: > >> Steven, > >> > >> Thanks for your KIP. I move this discussion to dev mailing list -- KIPs > >> need to be discussed there (and can be cc'ed to user list). > >> > >> Can you also add the KIP to the table "KIPs under discussion": > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-KIPsunderdiscussion > >> > >> > >> Thanks. > >> > >> > >> -Matthias > >> > >> On 2/6/17 3:35 PM, Steven Schlansker wrote: > >>> Hello users@kafka, > >>> > >>> I would like to propose a small KIP on the Streams framework > >>> that simply adds a KStream#peek implementation. > >>> > >>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-121%3A+Add+KStream+peek+method > >>> https://issues.apache.org/jira/browse/KAFKA-4720 > >>> https://github.com/apache/kafka/pull/2493 > >>> > >>> Please consider my contribution and hopefully you all like it and > agree that it should be merged into 0.10.3 :) > >>> If not, be gentle, this is my first KIP! > >>> > >>> Happy Monday, > >>> Steven > >>> > >> > > > > > > > > -- > > Gwen Shapira > > Product Manager | Confluent > > 650.450.2760 <(650)%20450-2760> | @gwenshap > > Follow us: Twitter | blog > >
