Hi Mattijs: We have not updated the wiki pages for config yet, and it will not be updated until we release 0.9 with these changes.
Currently consumers do have a commitOffsets function that can be called by the users, but for most use cases auto.commit is turned on and this function gets called by the consumer client itself. Guozhang On Mon, Feb 10, 2014 at 11:18 AM, Mattijs Ugen <akaid...@almost3.net> wrote: > Hey Neha, > > This looks really promising, I particularly like the ability to commit > offsets for topic/partition tuples over just commit(). Some remarks: > > - Constructors link to http://kafka.apache.org/documentation.html# > consumerconfigs for valid configurations, which lists zookeeper.connect > rather than metadata.broker.list, the value for BROKER_LIST_CONFIG in > ConsumerConfig. > - Docs for poll(long) mention consumer.commit(true), which I can't find in > the Consumer docs. For a simple consumer setup, that call is something that > would make a lot of sense. > - Love the addition of MockConsumer, awesome for unittesting :) > > Digging these open discussions on API changes on the mailing list btw, > keep up the good work :) > > Kind regards, > > Mattijs > -- -- Guozhang
