My bad - you're right. I either missed that bit or was looking at the 0.7 code. Hopefully the remainder of this thread answers your original question.
On Thu, Dec 6, 2012 at 7:07 AM, ben fleis <b...@monkey.org> wrote: > Since the v0.8 protocol wire changes went in, it's time for me to fix my > protocol things. One immediate question: > > > On Tue, Nov 27, 2012 at 1:32 AM, Joel Koshy <jjkosh...@gmail.com> wrote: > > > The requestId for each request-type is written out to the wire (see > > BoundedByteBufferSend) > > > > The code I find writes a requestId if it's attached, but looks perfect > content if not. This is the kind of thing that's very hard to infer, since > scanning all of the constructors, etc., is impractical. > > > > https://github.com/apache/kafka/blob/0.8/core/src/main/scala/kafka/network/BoundedByteBufferSend.scala#L42 > > But I assume this: you are sure that they really exist in all requests? (I > doubt myself, not you, but want to > > > Thanks, > > b >
