2018-01-20 20:23 GMT+01:00 Luca Toscano <toscano.l...@gmail.com>:
> Hi Yann,
>
> 2018-01-19 17:40 GMT+01:00 Yann Ylavic <ylavic....@gmail.com>:
>
>> On Fri, Jan 19, 2018 at 5:14 PM, Yann Ylavic <ylavic....@gmail.com>
>> wrote:
>> > On Fri, Jan 19, 2018 at 1:46 PM, Daniel <dferra...@gmail.com> wrote:
>> >> I vaguely recall some issue with reuse when using unix socket files so
>> >> it was deliberately set to off by default, but yes, perhaps someone
>> >> experienced enough with mod_proxy_fcgi inner workings can shed some
>> >> light on this and the why yes/not.
>> >>
>> >> With socket files I never tried to enable "enablereuse=on" and got
>> >> much successful results, so perhaps it's safer to keep it off until
>> >> someone clarifies this issue, after all when dealing with unix sockets
>> >> the access delays are quite low.
>> >
>> > {en,dis}ablereuse has no effect on Unix Domain Sockets in mod_proxy,
>> > they are never reused.
>>
>> Well, actually it shouldn't, but while the code clearly doesn't reuse
>> sockets (creates a new one for each request), nothing seems to tell
>> the recycler that it should close them unconditionally at the end of
>> the request.
>>
>
> Would you mind to point me to the snippet of code that does this? I am
> trying to reproduce the issue and see if there is a fd leak but didn't
> manage to so far..
>
I am now able to reproduce with Hajo's settings, and indeed with
enablereuse=on I can see a lot of fds leaked via lsof:
httpd 3230 3481 www-data 93u unix 0xffff9ada0cf60400 0t0
406770 type=STREAM
httpd 3230 3481 www-data 94u unix 0xffff9ada0cf60800 0t0
406773 type=STREAM
httpd 3230 3481 www-data 95u unix 0xffff9ada0cf66400 0t0
406776 type=STREAM
[..]
With Yann's patch I cannot seem them anymore, anche h2load does not stop at
50%/60% but completes without any issue. I am still not able to understand
why this happens reading the proxy_util.c code though :)
Luca
