I just had a look at your changes.
Are there more than one code the flashplayer returns? I thought it would just 
be a return code 1?

In that case I would favor a ... let's call it "boolean solution" ... sort of 
like. "linuxFlashPlayerQuirksModeEnabled" or something like that. Just a small 
sidehint on the HTML quirks mode ;-)

Having to define a list of ignorable return-codes sort of feels inconsequent. 
The other option would be to allow this on any operating system as I see no 
reason for having such a configuration Option just on linux. If I for example 
think about IntelliJ it would pick up the new property 
"flashplayerReturnCodesToIgnore" and offer that to the user as an option. He 
could be surprised why this only works on linux.

What do you think? I'm sort of asking anyone interested in contributing to this 
discussion.

Chris


________________________________________
Von: tjajab <[email protected]>
Gesendet: Montag, 8. September 2014 22:34
An: [email protected]
Betreff: Re: AW: AW: Flexmojos flexunit testing on headless Ubuntu 14.04

Hi Om,

The pull request is in chrisdutz/flexmojos (
https://github.com/chrisdutz/flexmojos/pull/10 )

Best,
Andreas


OmPrakash Muppirala wrote
> Which repo is this PR for?  I want to do some GitHub integration testing
> if
> possible.
>
> Thanks,
> Om





--
View this message in context: 
http://apache-flex-users.2333346.n4.nabble.com/Flexmojos-flexunit-testing-on-headless-Ubuntu-14-04-tp7894p7942.html
Sent from the Apache Flex Users mailing list archive at Nabble.com.

Reply via email to