(The pull request has been made : https://github.com/apache/camel/pull/1654)
Jonathan 2017-04-23 16:13 GMT+02:00 Jonathan Schoreels <[email protected]> : > Hi Claus, > > Thank you for the reminder, I had some other test with the repository and > found it another feature that seems to be normal : if the deadletter route > throws an exception, it will be send again to DLQ again, and again. I say > it's normal since a test seems to cover it : > JdbcAggregateRecoverDeadLetterChannelFailedTest. > > I however did not find if it's a behaviour that should be implemented in > ALL RecoverableAggregationRepository or only some of them. I've just > added javadoc for the JDBC's one, in doubt. > > Jonathan > > 2017-04-23 10:04 GMT+02:00 Claus Ibsen <[email protected]>: > >> Hi Jonathan >> >> Did you get a chance to do this? Its good to help the project if users >> can get involved and provide fixes/improvments. And a small javadoc >> contribution is a great place to start. >> >> On Wed, Apr 12, 2017 at 1:34 PM, Jonathan Schoreels >> <[email protected]> wrote: >> > Is it allowed to open pull request just to add java doc, or would you >> prefer >> > to do it yourself ? >> > >> > >> > On 2017-04-12 13:31, Claus Ibsen wrote: >> >> >> >> Yes only body + headers is stored that is by design >> >> >> >> On Wed, Apr 12, 2017 at 1:19 PM, Jonathan Schoreels >> >> <[email protected]> wrote: >> >>> >> >>> Hello, >> >>> >> >>> I've been using JdbcAggregationRepository recently and discovered >> that it >> >>> won't save the property in the table and thus, losing them at each >> >>> aggregation step. >> >>> >> >>> I know property are meant to be inner-route variable, and headers >> >>> metadata >> >>> for protocol/outer-scope, and that by definition, a >> >>> JdbcAggregationRepository is an outer service. However, at the same >> time, >> >>> it's an abstraction inside the route, and it's still very unsetting to >> >>> have >> >>> property that dissapear in the same camel route. >> >>> >> >>> Do you see it as a Bug or a Feature ? >> >>> >> >>> PS : I'm still asking myself why there is no user guide to use >> >>> JdbcAggregationRepository in the book (Hawt example) or a >> "pretty-doc" in >> >>> http://camel.apache.org/aggregator.html. Or maybe there is other more >> >>> standard way to aggregate in a persistent repository that I don't know >> >>> yet ? >> >>> >> >>> Thank you, >> >>> >> >>> Jonathan Schoreels >> >> >> >> >> >> >> > >> >> >> >> -- >> Claus Ibsen >> ----------------- >> http://davsclaus.com @davsclaus >> Camel in Action 2: https://www.manning.com/ibsen2 >> > >
