Hi Artyom, the private variable "destroyed" of org.apache.activemq.artemis.core.protocol.openwire was added by ARTEMIS-463[1] but ARTEMIS-3956[2] caused the issue removing isDestroyed from org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection. I think this issue should cause sending commands on destroyed connections, wasting resources and logging sending errors. Is it causing any errors in your environment?
[1] https://github.com/apache/activemq-artemis/commit/6ddf486f8f17776e14cef0c37ca2c9a6a891be7a [2] https://github.com/apache/activemq-artemis/commit/a0f39a4b28545f4010e07d950c34fe9f1f228b68 Regards, Domenico On Mon, 3 Jul 2023 at 10:36, Tarasenko, Artem (UIT) < artem.tarase...@union-investment.de> wrote: > The commit a0f39a4b28545f4010e07d950c34fe9f1f228b68 effectively makes > > > > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.isDestroyed() > to always return false for the OpenWire protocol: > > > > org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection > > > > has a private variable "destroyed" which hides the member of > AbstractRemotingConnection. > > > > I wonder how it went unnoticed for the past 10 Months, there must have > been an effect of this change. Or is this check is not used for OpenWire at > all? > > > > The fix for that would be trivial, just remove the one line in > OpenWireConnection, but I wonder what would be getting fixed by that. > > > > > > Regards, > > Artyom > >
