Hi Stefan, Thanks for fixing the license. I'll take a look at the code changes. This is one of those areas where I think we have the potential for speeding up the code, but also the potential for creating subtle problems. I'd like to make sure that these changes get tested very closely.
The changes I put in change the start-up negotiation, at least that is the intention. :) I'll send a message when the code is in there. Thanks again for contributing! - Jim On Thu, Aug 28, 2008 at 12:59 AM, Stefan_ <[EMAIL PROTECTED]> wrote: > > Hi Jim, > > Sorry, but I simple overlooked the license agreement. I uploaded the patch > again with the ASF license. > > I think adding the option to the URI is a good thing but Open Wire already > negotiated the NoDelay option at connection start up. Unfortunately NMS > hasn't yet supported this option so both the broker and the client use the > Nagle algorithm which results in delays when sending messages. > > BTW I also removed the flush method call after writing to the socket as I > recognized that this call also slows down the throughput. > > I would be very happy if the patch could be integrated into the source. > > Stefan > > > > semog wrote: > > > > Since I couldn't look at your code because of the license grant issue, > > I looked in to what you had mentioned about the NoDelay option. I > > took a stab at adding support for turning this (and several other > > socket transport options) on and off from the connection URI. Once > > you fix the license grant, I can look at your patch and integrate it > > in with my changes. > > > > The solution I am playing with would look like this: > > > > activemq:tcp://localhost:61616?connection.NoDelay=true > > > > This would turn off the Nagle algorithm on the socket connection. > > > > Thanks! > > -Jim > > > > > > -- > View this message in context: > http://www.nabble.com/Slow-performance-of-NMS-api-compared-to-Java-tp19158553p19195937.html > Sent from the ActiveMQ - User mailing list archive at Nabble.com. > >
