I didnt explain what the fix does, there is a new setting "struts.el.throwExceptionOnFailure" which when set to true, will cause missing properties, or exceptions thrown from OGNL expression evaluations, to throw an exception and "break" the page. This will only happen in S2 tags, not JSTL. Some testing and feedback would be appreciated.
musachy On Thu, Mar 19, 2009 at 10:12 PM, Musachy Barroso <musa...@gmail.com> wrote: > Patch committed to trunk. https://issues.apache.org/struts/browse/WW-3051 > > musachy > > On Wed, Mar 18, 2009 at 3:09 PM, Musachy Barroso <musa...@gmail.com> wrote: >> When a property is not found, it is logged, which causes all those >> warnings, as for myself I find them very annoying. I have a patch >> somewhere collecting dust, that throws exceptions when a property is >> not found, or there is an error evaluating an expression in a tag. I >> think we should take that route and only show errors when they happen >> in tags and not the stack in general (which produces all this noise) >> >> musachy >> >> On Wed, Mar 18, 2009 at 3:01 PM, hernan gonzalez <hgonza...@gmail.com> wrote: >>> "Struts 2.1 introduces more verbose logging than Struts 2.0. While >>> extremely valuable, some users may find these annoying." >>> http://cwiki.apache.org/S2WIKI/troubleshooting-guide-migrating-from-struts-20x-to-21x.html >>> >>> The extremely annoying thing is that struts 2.1 emits those warnings >>> (apparently) for each struts2 ui tag in each jsp page. ("Could not >>> find property [templateDir] ") >>> >>> In fact, a few (20 or 30) requests in my web application results in a >>> lot (about 1000) of warnings which are not (AFAIK) related to my >>> application, but to struts internals. >>> I like to be warned of missing properties in the stack, as they might >>> point to missing properies in my actions or bad spelt jsp tags... but >>> this is not very useful: >>> >>> # tail -n 2000 /usr/local/tomcat/logs/catalina.out | grep "Could not >>> find" | sed 's/http.* //' | sort | uniq -c >>> 24 WARN [[.freemarker.Request] >>> 24 WARN [[.freemarker.RequestParameters] >>> 29 WARN [[org.apache.catalina.jsp_file] >>> 29 WARN [[struts.valueStack] >>> 864 WARN [[templateDir] >>> 192 WARN [[theme] >>> >>> And no solution is provided, except for disabling those warnings completely. >>> I'd like to know if that implies something wrong (or slightly wrong) >>> about my jsp pages, or about struts. >>> >>> Hernán >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org >>> For additional commands, e-mail: user-h...@struts.apache.org >>> >>> >> >> >> >> -- >> "Hey you! Would you help me to carry the stone?" Pink Floyd >> > > > > -- > "Hey you! Would you help me to carry the stone?" Pink Floyd > -- "Hey you! Would you help me to carry the stone?" Pink Floyd --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscr...@struts.apache.org For additional commands, e-mail: user-h...@struts.apache.org
