I don't know if it's *explicitly* a bad practice, but it's pretty easy to
hose things up with arbitrary static method access.

Personally, I wouldn't, and would instead defer things like that to a
custom tag or, as you said, a method in the base class, properly named,
allowing simple getter access without the parens.

Dave



On Tue, Jul 23, 2013 at 12:48 PM, Antonio Sánchez
<juntandolin...@gmail.com>wrote:

> Thank you.
>
> Is it discouraged or is it considered a bad practice to use static code in
> OGNL? It is disallowed by default.
>
> Actually, the code would be something like:
>
> <s:if test="%{@com.company.project.package.Util@isUserInSession()}">
>
> Do you think it is a better practice to use a base class whenever possible?
>
> <s:if test="%{userInSession()}"> looks simpler.
>
>
>
> El Martes, 23 de julio de 2013 07:37:17 Dave Newton escribió:
> > Enable static method access:
> >
> >     <constant name="struts.ognl.allowStaticMethodAccess" value="true"/>
> >
> > Then use OGNL's static method notation [1]:
> >
> >     <s:if test="%{@Util@isUserInSession()}">
> >
> >
> > Dave
> >
> > [1]
> >
> http://struts.apache.org/release/2.3.x/docs/ognl-basics.html#OGNLBasics-Accessingstaticproperties
> >
> >
> >
> > On Tue, Jul 23, 2013 at 7:27 AM, Antonio Sánchez
> > <juntandolin...@gmail.com>wrote:
> >
> > > Hi.
> > >
> > > How can I use utilities classes inside JSPs?
> > >
> > > For instance, currently I'm using:
> > >
> > > <s:if test="#session.USER == null">
> > >
> > > for asking if user is in session, but I wan to use a Java method
> instead.
> > >
> > > One option is defining a basic Action class and make all action extend
> it,
> > > but in some cases I rather prefer something like:
> > >
> > > Util.instance().isUserInSession() or
> > >
> > > Util.isUserInSession(),
> > >
> > > and
> > >
> > > <s:if test="isUserInSession()">
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> > > For additional commands, e-mail: user-h...@struts.apache.org
> > >
> > >
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
> For additional commands, e-mail: user-h...@struts.apache.org
>
>


-- 
e: davelnew...@gmail.com
m: 908-380-8699
s: davelnewton_skype
t: @dave_newton <https://twitter.com/dave_newton>
b: Bucky Bits <http://buckybits.blogspot.com/>
g: davelnewton <https://github.com/davelnewton>
so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>

Reply via email to