That's waiting for a review as seen. There have been few discussions about this. I am personally against closing only because it is old.
I have made periodically PRs to close other inactive PRs (e.g., not responsive to review comments or Jenkins failures). So, I guess most of such PRs are waiting for a review. How about drawing attention to the PRs you see a value on with a proper explanation and investigation, or try to review rather than suggesting just closing? I think anyone in this community can review. 2017-07-26 11:58 GMT+09:00 萝卜丝炒饭 <1427357...@qq.com>: > Hi all, > > I find some PR were created one year ago, the last comment is several > monthes before. > No one to close or reject it. > Such as 6880, just put it like this? > > > ---Original--- > *From:* "Hyukjin Kwon"<gurwls...@gmail.com> > *Date:* 2017/7/25 09:25:28 > *To:* "萝卜丝炒饭"<1427357...@qq.com>; > *Cc:* "user @spark"<user@spark.apache.org>;"Marcelo Vanzin"< > van...@cloudera.com>; > *Subject:* Re: how to set the assignee in JIRA please? > > I think that's described in the link I used - http://spark.apache.org/cont > ributing.html. > > On 25 Jul 2017 10:22 am, "萝卜丝炒饭" <1427357...@qq.com> wrote: > > Another issue about contribution. > > After a pull request is created, what should creator do next please? > Who will close it please? > > ---Original--- > *From:* "Hyukjin Kwon"<gurwls...@gmail.com> > *Date:* 2017/7/25 09:15:49 > *To:* "Marcelo Vanzin"<van...@cloudera.com>; > *Cc:* "user"<user@spark.apache.org>;"萝卜丝炒饭"<1427357...@qq.com>; > *Subject:* Re: how to set the assignee in JIRA please? > > I see. In any event, it sounds not required to work on an issue - > http://spark.apache.org/contributing.html . > > "... There is no need to be the Assignee of the JIRA to work on it, though > you are welcome to comment that you have begun work.." > > and I was just wondering out of my curiosity. It should be not a big deal > anyway. > > > Thanks for the details. > > > > 2017-07-25 10:09 GMT+09:00 Marcelo Vanzin <van...@cloudera.com>: > >> On Mon, Jul 24, 2017 at 6:04 PM, Hyukjin Kwon <gurwls...@gmail.com> >> wrote: >> > However, I see some JIRAs are assigned to someone time to time. Were >> those >> > mistakes or would you mind if I ask when someone is assigned? >> >> I'm not sure if there are any guidelines of when to assign; since >> there has been an agreement that bugs should remain unassigned I don't >> think I've personally done it, although I have seen others do it. In >> general I'd say it's ok if there's a good justification for it (e.g. >> "this is a large change and this person who is an active contributor >> will work on it"), but in the general case should be avoided. >> >> I agree it's a little confusing, especially comparing to other >> projects, but it's how it's been done for a couple of years at least >> (or at least what I have understood). >> >> >> -- >> Marcelo >> > > >
