We do fix some spotbugs issues - but we are not zealots - we have annotations in some places to prevent warnings. If you feel strongly about any code, submit a PR.
Any volunteer who wants to sort it out so we have zero spotbugs issues, code submissions are very welcome. On Tuesday 2 November 2021, 12:32:22 GMT+1, Andreas Reichel <andr...@manticore-projects.com> wrote: Greetings. Fiddling around with the Gradle Build process, I spotted a lot of SpotBugs violations. While I am not a SpotBugs zealot (and usually would consider only of the most critical exceptions), I wonder: What are we doing with these exceptions? Please correct me if I am wrong: It looks like all the exceptions are reported and nothing is done about it? If so, would it not make sense to: 1) define the SpotBugs Exceptions we actually do want to care about (e. g. a customized Prio 1 list) 2) then clean out those in the code and 3) then enforce it during the acceptance of PRs in order to ensure that never eva such an exception makes it into the code base again? Am I missing something from my naive point of view? Best regards Andreas --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscr...@poi.apache.org For additional commands, e-mail: user-h...@poi.apache.org
