Hi Nicolas,
Thank you for taking the time to look at this.
I am available for a call / chat on Slack as well.
I would really love to see this through.
The short term goal of the PR:
- show that we can have OFBiz parts as libraries that we can publish and
reuse. No more mandatory rebase, but still an option.
- extract enough of OFBiz to allow splitinmg more as library
Medium term goal is entity engine library and service engine library.
Being able to use parts of OFBiz as librarries opens up a whole new
world of posibilities: tooling and integrations that are hard /
impossible to do.
Also having libraries - makes code more robust - forces out dependencies
and is easier to reason about when making changes.
If I work on EntityEngine for example, I should not care about widget
rendering or service layer that much since those should sit on top / be
orthogonal to DB layer. Right now, every OFBiz change needs to take ALL
of OFBiz into account, incluing private installations - since they might
break.
Doing the refactoring exercise surfaced a lot of cyclic dependencies
between OFBiz classes and parts.
Did you know entity engine code depends on widget rendering code or
service execution code?
I find that to be peculiar since I would think the dependency should be
the other way around. (Well the dependency is cyclcic unfortunatelly).
I think I will record the next session so people can watch it.
It makes explainig much easier to follow IMO.
Regards,
Eugen
La 13.12.2023 12:41, Nicolas Malin a scris:
Hi Eugen
Le 08/12/2023 à 19:05, Eugen Stan a écrit :
Thanks Nicolas,
Merging git / rebasing does not sound like a fun operation.
How does it go in practice?
How often do you encounter conflicts and how easy it is to deal with
them.
Do you usually make changes to the ofbiz source code?
How do you add new components?
I live with it well :) because we don't touch the framework and try to
work mostly on dedicate plugin.
The reason that we tried to improve OFBiz to support most extend cases
through the plugin.
I am doing some research to support my PR
https://github.com/apache/ofbiz-framework/pull/678 .
Yeah when we are on refactoring process I agree it's pain.
I believe publishing libraries will open up new deployment options.
Would love to hear your thoughs on that if you have time to check it out.
I started a review of your PR, I'll try to do a constructive return, the
time that I understand well your goal.
Thanks for your work Eugen !
Nicolas
Regards,
Eugen
La 08.12.2023 15:25, Nicolas Malin a scris:
Hello Eugen,
From our side, we have the ofbiz-framework dedicate on each project
on our gitlab.
We add the official repo on available git remote, fetch and merge the
wanted branch on the following local branch.
After rebase all depending branch to keep all up to date.
If you are not connected to git, I think the better way is retrieve
the patch between two release tags.
Nicolas
Le 08/12/2023 à 14:12, Eugen Stan a écrit :
Hi,
How does one upgrade OFBiz from one release to the other?
Do you clone the repo and rebase your changes?
Regards,
--
Eugen Stan
+40770 941 271 / https://www.netdava.com
