Brian, on your last question, it is a good point to keep this "data" (photo's) separate from the "code" (the war). Using a (rather abstract definition of) a resource might be little overkill, I would be satisfied with the current option, but maybe other users would like to see more/other things.
regards, Harry On 18 January 2014 17:10, Brian Burch <[email protected]> wrote: > On 18/01/14 13:09, Harry Metske wrote: > >> Brian, >> >> I played around a bit with the PhotoCollectionPlugin, a nice combination >> of >> wiki and photo collections. >> > > Thanks for trying it. > > > I found just two minor issues : >> >> * The values for photoCollection.default.phototype appear to be case >> sensitive (I had to add lowercase .png .jpg to get it working). I think >> they should be case insensitive. >> > > I agree with you. > > When I originally wrote the plugin most cameras made JPG's, but my wife's > Android phone makes jpg's. I add JPG to my /etc/mime.types to get most > tools to handle the JPG file type, so I haven't picked up on your issue > since I wrote the original code. > > I should probably add support for *.jpeg at the same time, because that > exists in mime.types too. > > > * The photoCollection.collection.base is always considered relative to >> the >> webapp, even if you start it's value with a "/". You are forced to fiddle >> in your installed war, even if you use symlinks (and start making >> questionable changes to the tomcat configuration). In general we like to >> stay away from "war surgery", and therefore you should be able to use >> absolute paths for this property. >> > > You have a good point. My next enhancement was to investigate handling the > entire PhotoCollection as resources rather than Files. Do you think that is > a good potential approach for fetching the collection - I think it > would/should always be located outside the webapp directory? > > > Thanks for your efforts ! >> > > No problem. I'm pleased to help when I have time to spare, or when jspwiki > reaches the top of my priority list. I'm usually an "if it aint broke, dont > fix it" kind of guy... > > Brian > > > kind regards, >> Harry >> >> >> >> On 17 January 2014 14:03, Dave Koelmeyer <dave.koelmeyer@davekoelmeyer. >> co.nz >> >>> wrote: >>> >> >> >>> On 18/01/14 01:01, Brian Burch wrote: >>> >>> My PhotoCollectionPlugin has been available for JSPWiki 2.8 >>>> (com.eycrd.jspwiki packages) for several years. I have just converted >>>> it to >>>> run under the apache releases. I have tested it against 2.10, running >>>> under >>>> ubuntu 13.10, OpenJDK 1.7.0_25 and apache Tomcat 7.0.42. >>>> >>>> >>> >>> Awesome! >>> >>> -- >>> Dave Koelmeyer >>> http://blog.davekoelmeyer.co.nz >>> >>> >>> >>> >> >
