Hi Nick!
Thanks for your response!
I've tried to remove this line from your PR, and from typedef struct
ssh_auth_agent as well, but am currently facing another error.
Please see stacktrace in attachment
Thanks and best regards
Aliaksei Kisel, Software Engineer
вс, 29 окт. 2023 г. в 21:32, Nick Couchman <[email protected]>:
> On Sun, Oct 29, 2023 at 11:46 AM Aliaksei Kisel <[email protected]>
> wrote:
>
>> Hello team!
>> I have a question related to
>> https://issues.apache.org/jira/browse/GUACAMOLE-1658 issue.
>> As I see from the ticket issue hasn’t been fixed yet. So I want to ask if
>> you have any hot fix or work around for it.
>> I would be very grateful if you could help me find a solution to the
>> problem.
>>
>>
> First of all, please do not cross-post to multiple lists, please select
> one list and post to that one. I'm responding on the user@ list, only.
>
> Thanks for the reminder - this is a relatively simple fix that just
> requires removing a couple of lines in the ssh_agent.h file. I've submitted
> the pull request for this - not sure why I hadn't done that a long time ago.
>
> -Nick
>
{\rtf1\ansi\ansicpg1251\cocoartf2709
\cocoatextscaling0\cocoaplatform0{\fonttbl\f0\fswiss\fcharset0 Helvetica;}
{\colortbl;\red255\green255\blue255;}
{\*\expandedcolortbl;;}
\paperw11900\paperh16840\margl1440\margr1440\vieww30040\viewh18340\viewkind0
\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0
\f0\fs24 \cf0 77.99 make[2]: Entering directory '/tmp/guacamole-server/src/protocols/ssh'\
77.99 CC libguac_client_ssh_la-argv.lo\
78.10 CC libguac_client_ssh_la-client.lo\
78.17 CC libguac_client_ssh_la-clipboard.lo\
78.24 CC libguac_client_ssh_la-input.lo\
78.30 CC libguac_client_ssh_la-pipe.lo\
78.36 CC libguac_client_ssh_la-settings.lo\
78.43 CC libguac_client_ssh_la-sftp.lo\
78.50 CC libguac_client_ssh_la-ssh.lo\
78.57 ssh.c: In function 'ssh_client_thread':\
78.57 ssh.c:323:19: error: 'guac_ssh_client' has no member named 'enable_agent'\
78.57 323 | if (ssh_client->enable_agent) \{\
78.57 | ^~\
78.58 ssh.c:325:17: error: 'LIBSSH2_CALLBACK_AUTH_AGENT' undeclared (first use in this function); did you mean 'LIBSSH2_CALLBACK_AUTHAGENT'?\
78.58 325 | LIBSSH2_CALLBACK_AUTH_AGENT, (void*) ssh_auth_agent_callback);\
78.58 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~\
78.58 | LIBSSH2_CALLBACK_AUTHAGENT\
78.58 ssh.c:325:17: note: each undeclared identifier is reported only once for each function it appears in\
78.58 ssh.c:324:48: error: passing argument 1 of 'libssh2_session_callback_set' from incompatible pointer type [-Werror=incompatible-pointer-types]\
78.58 324 | libssh2_session_callback_set(ssh_client->session,\
78.58 | ~~~~~~~~~~^~~~~~~~~\
78.58 | |\
78.58 | guac_common_ssh_session *\
78.58 In file included from ../../../src/common-ssh/common-ssh/key.h:26,\
78.58 from ../../../src/common-ssh/common-ssh/user.h:23,\
78.58 from ../../../src/common-ssh/common-ssh/ssh.h:23,\
78.58 from ../../../src/common-ssh/common-ssh/sftp.h:24,\
78.58 from ssh.c:23:\
78.58 /opt/guacamole/include/libssh2.h:618:65: note: expected 'LIBSSH2_SESSION *' \{aka 'struct _LIBSSH2_SESSION *'\} but argument is of type 'guac_common_ssh_session *'\
78.58 618 | LIBSSH2_API void *libssh2_session_callback_set(LIBSSH2_SESSION *session,\
78.58 | ~~~~~~~~~~~~~~~~~^~~~~~~\
78.58 cc1: all warnings being treated as errors\
78.59 make[2]: Leaving directory '/tmp/guacamole-server/src/protocols/ssh'\
78.59 make[2]: *** [Makefile:629: libguac_client_ssh_la-ssh.lo] Error 1\
78.59 make[1]: *** [Makefile:544: all-recursive] Error 1\
78.59 make[1]: Leaving directory '/tmp/guacamole-server'\
78.59 make: *** [Makefile:464: all] Error 2\
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
