On Mon, Mar 29, 2021 at 7:01 AM Philippe MARASSE <[email protected]> wrote:
> Never done a git bisect before :-) after 7 steps, its done : > > $ git bisect bad > f21a7c63ebc105eb26eb5adf91c8e65e1f99e014 is the first bad commit > commit f21a7c63ebc105eb26eb5adf91c8e65e1f99e014 > Author: Michael Jumper <[email protected]> <[email protected]> > Date: Thu May 28 19:01:13 2020 -0700 > > GUACAMOLE-1298: Migrate to latest version of Guice and Jersey 2.x > > :040000 040000 3abc05f30b6fc345a06ecd31c7c946d94bb5a687 > bb8145256d75dc5c98e2d0ba0fbc72680e463962 M guacamole > > Luckily, the issue is straigthforward to test : no need to reset database > between tests, just bisect, mvn clean package, deploy, restart tomcat and > login. > I think this is due to the change in JSON annotations between the versions of Jackson used before and after the Jersey 2.x migration. The package names for the annotations used to override default property names changed from "org.codehaus.jackson.annotate" to "com.fasterxml.jackson.annotation", and classes annotated with the older annotations will not serialize to the same JSON: https://issues.apache.org/jira/browse/GUACAMOLE-1298?focusedCommentId=17296725&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17296725 The custom field used by the TOTP auth uses these annotations, and might not be producing different JSON now, causing unexpected behavior by the client-side code. This might be resolved by the changes I'm finishing up now: https://github.com/mike-jumper/guacamole-client/tree/fix-dependencies Michael Jumper CEO, Lead Developer Glyptodon Inc <https://enterprise.glyptodon.com/>.
