Could you expand a bit on possible alternative implementations that
require this interface to become public, opposed to providing more
built-in ways to subscribe?
On 13/04/2022 11:26, Qingsheng Ren wrote:
Thanks for the proposal Mason! I think exposing `KafkaSubscriber` as public API
is helpful for users to implement more complex subscription logics.
+1 (non-binding)
Cheers,
Qingsheng
On Apr 12, 2022, at 11:46, Mason Chen <mas.chen6...@gmail.com> wrote:
Hi Flink Devs,
I was looking to contribute to
https://issues.apache.org/jira/browse/FLINK-24660, which is a ticket to track
changing the KafkaSubscriber from Internal to PublicEvolving.
In the PR, it seems a few of us have agreement on making the subscriber
pluggable in the KafkaSource, but I'd like to raise the question nevertheless.
Furthermore, there is also interest from various Flink mailing threads and on
the Jira ticket itself for the ticket, so I think the change would be
beneficial to the users. There is already some feedback to make the contract of
handling removed splits by the KafkaSource and subscriber clearer in the docs.
I have yet to address all the PR feedback, but does anyone have any concerns
before I proceed further?
Best,
Mason
