Hi Gary,
I can confirm that this fixed the issue. Our tests are green again with
current master. Thanks a lot for your quick response and fix!
Andreas
Gary Gregory wrote on 02.01.24 17:27:
I fixed this in git master and 2.16.0-SNAPSHOT builds.
Please test and report back! 🙂
Gary
On Tue, Jan 2, 2024, 11:03 AM Gary Gregory<garydgreg...@gmail.com> wrote:
Ah, intersection, I'll look into it.
Gary
On Tue, Jan 2, 2024, 9:50 AM Andreas Hubold
<andreas.hub...@coremedia.com.invalid> wrote:
Hi Gary,
right, but it is optional for external entities, see
https://www.w3.org/TR/xml/#TextEntities
And the examples inhttps://www.w3.org/TR/xml/#NT-EncodingDecl also
don't have version attributes, so this might still be a valid use case?
<?xml encoding='UTF-8'?>
<?xml encoding='EUC-JP'?>
Cheers
Andreas
Gary Gregory schrieb am 02.01.24 um 15:42:
[Sie erhalten nicht häufig e-mailsvongarydgreg...@gmail.com. Weitere
Informationen, warum dies wichtig ist, finden Sie unterhttps://
aka.ms/LearnAboutSenderIdentification ]
Hi Andreas,
In an "xml" PI, the "version" is NOT optional, see
https://www.w3.org/TR/REC-xml/#sec-pi
If we tried to handle all cases of invalid documents, then there would
be no end to it.
Gary
On Tue, Jan 2, 2024 at 9:36 AM Gary Gregory<garydgreg...@gmail.com>
wrote:
Ah, you are talking about something different, I am sorry about that.
Looking...
Gary
On Tue, Jan 2, 2024 at 9:35 AM Gary Gregory<garydgreg...@gmail.com>
wrote:
Hello Andrea,
Please try git master or a 2.16.0-SNAPSHOT build
(
https://repository.apache.org/content/repositories/snapshots/commons-io/commons-io/2.16.0-SNAPSHOT
)
I fixed this today as reported inhttps://
github.com/apache/commons-io/pull/550
TY!
Gary
On Tue, Jan 2, 2024 at 9:33 AM Andreas Hubold
<andreas.hub...@coremedia.com.invalid> wrote:
Hi,
the regular expression for the encoding was changed in
XmlStreamReader
between 2.13.0 and 2.15.1.
It now requires a version attribute in the XML declaration and does
not
work anymore with some real world files.
For example, the encoding from the following example declaration is
respected by 2.13.0, but not by 2.15.1
<?xml encoding='Cp1047'?>
It works if the version is specified: <?xml version="1.0"
encoding='Cp1047'?>
However note, thathttps://www.w3.org/TR/xml/#NT-EncodingDecl also
mentions examples without version attribute, at least for entities.
It
would be good to restore the previous behavior, IMHO.
Cheers,
Andreas
---------------------------------------------------------------------
To unsubscribe,e-mail:user-unsubscr...@commons.apache.org
For additional commands,e-mail:user-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe,e-mail:user-unsubscr...@commons.apache.org
For additional commands,e-mail:user-h...@commons.apache.org
