Thanks guys, I was looking at the 2.38 version and that’s was why I didn’t see Danny’s change.
Do you know if there are small changes that would be a good first issue to tackle? Thanks, Kane On 6 Jun 2022, at 16:12, Danny McCormick <dannymccorm...@google.com<mailto:dannymccorm...@google.com>> wrote: Hey Kane, I also agree that it's a good idea, but I actually did this last month<https://github.com/apache/beam/blob/4dce7b8857f37608321253073745fe7611a48af9/sdks/go/pkg/beam/core/graph/mtime/time.go#L77> as part of a separate effort (it's part of the newest 2.39 release). Thanks for the willingness to jump in though, I always love to see more people getting involved with the Go SDK! Thanks, Danny On Mon, Jun 6, 2022 at 11:08 AM Jack McCluskey <jrmcclus...@google.com<mailto:jrmcclus...@google.com>> wrote: Hey Kane, That sounds like a good addition! If you'd file an issue for tracking and submit a PR that'd be awesome. I'm happy to help with anything you might need to get this in! Thanks, Jack McCluskey On Mon, Jun 6, 2022 at 11:03 AM Kane Knight <k...@hoxtonanalytics.com<mailto:k...@hoxtonanalytics.com>> wrote: I’ve noticed in the mtime package (go/pkg/beam/core/graph/mtime/<https://goto.google.com/pkg/beam/core/graph/mtime/>time.go), there is a function FromTime which takes a time.Time and returns a mtime.Time. In my own project I’ve needed to convert to time.Time and to do so I needed to first convert to milliseconds and the use those milliseconds to create a new time.Time. Instead, I propose we create a new function ToTime, which will take an mtime.Time and return a time.Time. I would be happy to create the issue on the GitHub project and then create the pr, however, this is my first issue on this project and I thought I would run it by everyone first. Thanks, Kane Knight
