From: Julia Lawall <ju...@diku.dk> Test the result of kmalloc using a ! test, as most commonly done elsewhere, rather than a test on 0.
The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression *x; identifier f; constant char *C; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ... when != x == NULL when != x != NULL when != (x || ...) ( kfree(x) | f(...,C,...,x,...) | *f(...,x,...) | *x->f ) // </smpl> Signed-off-by: Julia Lawall <ju...@diku.dk> --- fs/hppfs/hppfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c index a5089a6..b705a3c 100644 --- a/fs/hppfs/hppfs.c +++ b/fs/hppfs/hppfs.c @@ -385,7 +385,7 @@ static struct hppfs_data *hppfs_get_data(int fd, int filter, break; new = kmalloc(sizeof(*data), GFP_KERNEL); - if (new == 0) { + if (!new) { printk(KERN_ERR "hppfs_get_data : data allocation " "failed\n"); err = -ENOMEM; ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ User-mode-linux-user mailing list User-mode-linux-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-user
