As long as it doesn’t break autocomplete, I think moving the square brackets is a good idea. It makes it more accurate and clear that wildcard is what can be optionally omitted but regex must be included.
Thanks, Brian On Oct 23, 2018, 4:54 PM -0500, Monte Goulding via use-livecode <use-livecode@lists.runrev.com>, wrote: > > > > On 24 Oct 2018, at 8:40 am, Monte Goulding via use-livecode > > <use-livecode@lists.runrev.com> wrote: > > > > Hmm… the syntax just describes valid syntax rather than how it behaves so > > I’m not sure if the change suggested above adds much. > > > > The docs do state: > > > > If a regex pattern is specified, the filterPattern evaluates to a regular > > expression. > > > > Perhaps we just need a note stating that the pattern is presumed to be a > > wildcard if the pattern type is not explicitly specified via regex pattern > > or wildcard pattern. > > Hmm… looking at Sean’s PR I see down further there is this: > > If no filterPattern type is specified, the filterPattern is handled as a > wildcard. > > So all the info is there and interestingly I missed it myself. Sean’s PR does > move the regex info I quoted above next to it which is good as currently one > might ignore the rest once you hit the wildcard pattern description thinking > it is no longer relevant to regex. I have suggested Sean also highlight that > line by making it a block quoted note. > > Cheers > > Monte > _______________________________________________ > use-livecode mailing list > use-livecode@lists.runrev.com > Please visit this url to subscribe, unsubscribe and manage your subscription > preferences: > http://lists.runrev.com/mailman/listinfo/use-livecode _______________________________________________ use-livecode mailing list use-livecode@lists.runrev.com Please visit this url to subscribe, unsubscribe and manage your subscription preferences: http://lists.runrev.com/mailman/listinfo/use-livecode
