Hi Panos,

in the bug report you link to a pull request which was removed for some reasons.

Why not checking for emptiness of the externals folder and delete it seperately 
for each platform after the standalone was build and maybe only for Win and 
Linux, 
Either in the reSaveAsMacStandalone, revSaveAsWindowsStandalone, 
revSaveAsLinuxStandalone handlers and or combined in the currently empty 
revStandalonePostBuild handler of the stack revSaveAsStandalone?

Would this avoid the problems Mark Waddingham was concerned about?

I've added this code block here as a test at the end of the 
revSaveAsWindowsStandalone directly before the line with the call to 
revStandalonePostBuild 
This works so far.

if pFolder ends with "Windows"
-- standalones for both Win platforms were created (32 and 64 bit)

-- or for one Win platform and at least for one other non windows platform

then

-- first delete the empty externals folder in Windows 32bit folder in case it 
exists

if there is a folder (pfolder&"/externals") \

and files(pFolder &"/externals") is empty \

and folders(pfolder&"/externals") = ".."

then

delete folder pfolder&"/externals"

end if

-- then delete empty externals folder in Windows 64bit folder in case it exists

if there is a folder (pfolder&&"x86-64/externals") \

and files(pFolder && "x86-64/externals") is empty \

and folders(pfolder && "x86-64/externals") = ".."

then

delete folder pfolder && "x86-64/externals"

end if

else

-- a standalone either for Windows x86-32 or X86-64 and for no other platform, 
macOS or Linux , was created

if there is a folder (pfolder&"/externals") \

and files(pFolder &"/externals") is empty \

and folders(pfolder&"/externals") = ".."

then

delete folder pfolder&"/externals"

end if

end if


> Am 21.03.2022 um 17:08 schrieb panagiotis m via use-livecode 
> <use-livecode@lists.runrev.com>:
> 
> Hello all,
> 
> There is a bug report about it:
> 
> https://quality.livecode.com/show_bug.cgi?id=20223
> 
> Cheers,
> Panos
> --
> 
> On Mon, 21 Mar 2022 at 17:06, Klaus major-k via use-livecode <
> use-livecode@lists.runrev.com> wrote:
> 
>> Hi Matthias,
>> 
>>> Am 21.03.2022 um 15:41 schrieb Matthias Rebbe via use-livecode <
>> use-livecode@lists.runrev.com>:
>>> 
>>> Short answer, no. I always delete that folder, if it’s empty.
>> 
>> thank you very much!
>> 
>> 
>> Best
>> 
>> Klaus
>> --
>> Klaus Major
>> https://www.major-k.de
>> https://www.major-k.de/bass
>> kl...@major-k.de
>> 
>> 
>> _______________________________________________
>> use-livecode mailing list
>> use-livecode@lists.runrev.com
>> Please visit this url to subscribe, unsubscribe and manage your
>> subscription preferences:
>> http://lists.runrev.com/mailman/listinfo/use-livecode
>> 
> _______________________________________________
> use-livecode mailing list
> use-livecode@lists.runrev.com
> Please visit this url to subscribe, unsubscribe and manage your subscription 
> preferences:
> http://lists.runrev.com/mailman/listinfo/use-livecode

_______________________________________________
use-livecode mailing list
use-livecode@lists.runrev.com
Please visit this url to subscribe, unsubscribe and manage your subscription 
preferences:
http://lists.runrev.com/mailman/listinfo/use-livecode

Reply via email to